Reduced cyclomatic complexity of BMAttack->commit_attack()
Reduced cyclomatic complexity of BMAttackSkill->validate_attack()
Fixed UnusedFormalParameter warnings in BMAttackSkill->is_direct_attack_valid()
Changed visibility of BMDie properties to enable use of getters and setters
Refactored BMDie->__set() and BMGame->__set to call set_*() functions
- Removed UnusedFormalParameter warnings
- Refactored BMDieTwin->describe()
Refactored BMGame->set__attack() and BMGame->set__buttonArray() to reduce cyclomatic complexity
Refactored BMGameAction->friendly_message_attack() to reduce cyclomatic complexity
Refactored BMGame->__get() to reduce cyclomatic complexity
Refactored BMGame->react_to_initiative_decline() to reduce cyclomatic complexity
Refactored BMGame->react_to_initiative_focus() to reduce cyclomatic complexity
Fixed checkstyle errors
Merge remote-tracking branch 'upstream/master' into 417_pmd_reduction
Fixed refactoring of BMGame->react_to_initiative_focus()
Refactored BMGame->getJsonData()
Continued refactoring of BMGame->getJsonData() subfunctions
Finished refactoring of BMGame->getJsonData() subfunctions
Refactored DummyApiResponder load functions
Fixed bugs in DummyApiResponder to make QUnit tests pass
Fixed PMD warnings for DummyApiResponder