Just a heads-up: I believe there are some pro tests that use stored proc
stats calls on the replicated cluster as a means of validating transaction
propagation -- these tests will likely start failing and have to be
reworked to not expect any AdHoc_RO_ contribution to the stats.

Also, I'm not 100% confident in the various things we test in various
places under various conditions for various purposes to distinguish RO ad
hoc from RW. There was this one spot that seemed particularly dodgy to me
-- I'll try to locate it again. My current point being that switching
AdHoc_RO to non-durable may be theoretically simple and beneficial, but it
MAY risk introducing bad consequences for any mis-characterized RW cases
that may currently be getting glossed over.


On Fri, Jan 3, 2014 at 2:16 PM, Anish Khanzode <notifications@github.com>wrote:

> In src/frontend/org/voltdb/SystemProcedureCatalog.java:
>
> > @@ -121,31 +125,31 @@ Procedure asCatalogProcedure() {
> >
> >      static {                                                                                            // SP     RO     Every  Param ParamType Pro  (DR: kill, skip, replica-ok)
> >          ImmutableMap.Builder<String, Config> builder = ImmutableMap.builder();
> > -        builder.put("@AdHoc_RW_MP",             new Config("org.voltdb.sysprocs.AdHoc_RW_MP",              false, false, false, 0, VoltType.INVALID,   false, false, false, true));
> > -        builder.put("@AdHoc_RW_SP",             new Config("org.voltdb.sysprocs.AdHoc_RW_SP",              true,  false, false, 0, VoltType.VARBINARY, false, false, false, true));
> > -        builder.put("@AdHoc_RO_MP",             new Config("org.voltdb.sysprocs.AdHoc_RO_MP",              false, true,  false, 0, VoltType.INVALID,   false, false, false, true));
> > -        builder.put("@AdHoc_RO_SP",             new Config("org.voltdb.sysprocs.AdHoc_RO_SP",              true,  true,  false, 0, VoltType.VARBINARY, false, false, false, true));
>
> Yes I am just replacing it with flag in sysprocs which is what you had
> commented as TODO. I will make RO non durable.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/VoltDB/voltdb/pull/1058/files#r8642166>
> .
>