working on controller