almost done just need the rspec tests