good point, I will null it out


On Tue, Apr 22, 2014 at 2:09 PM, Matthew Story <notifications@github.com>wrote:

> In spokec:
>
> > @@ -143,6 +145,13 @@ def _spokify(js, css, html, out, path):
> >          _encoded_write(h, out, 'html', path)
> >          out.write('"));\n')
> >
> > +    out.flush()
> > +
> > +    for j in _list_coerce(extjs):
> > +        subprocess.call(shlex.split(j), stdout=out)
>
> by not nulling stderr here, spokec's stderr is going to get all stderr
> from the child process (which is probably desirable), similarly by not
> nulling stdin child process will have access to spokec's stdin (which is
> probably not desirable).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/axialmarket/spoke/pull/4/files#r11867251>
> .
>



-- 
Ben Holzman
Lead Engineer, Axial Corps of Engineers
45 East 20th Street, 12th Floor
New York, NY 10003
cell: 917-582-4221

axialcorps.wordpress.com | github.com/axialmarket/ | twitter.com/axialcorps

Factum non Verbum