Convert to expect syntax

* Upgrade to rspec 2.99
* Change to expect syntax
* Change one-liners to `is_expected` syntax
* Fix hound warnings on long lines
* Fix ruby warnings re: `match` rspec matcher (add parens around regex)
Remove spec causing deprecation warnings

You can't call `visit` in controller specs, and just using the `feature`
DSL in a controller spec is not enough to get around this. Rather than
moving this to a feature spec that would require all the setup and mocks
seen here, I've opted to remove the spec.