analysis: nit
search: do not return CBF=0 distortion from xEstimateResidualQT()

it can be calculated easily if needed
search: rename xSetResidualQTData to saveResidualQTData and simplify
search: move checkIntra from Analysis to Search

This function didn't belong in Analysis
search: remove redundant clearCbf call

The logic would not get here if cu->getQtRootCbf(0) didn't return zero, which
implies all three CBF flags are already zero
encoder: make assignments to Frame::m_intraData and m_interData unconditional

The check doesn't help anyone. If pic_in->analysisData.intraData was NULL, the
Frame fields are entirely uninitialized.
search: simplify checkTransformSkip logic

drop !!qp condition, this doesn't appear necessary. we already check for TQ
bypass
search: clarify --rdpenalty
search: use member variable access to current slice and frame, not the cu's
search: fix --rdpenalty=2 at --rd 0,1

It needed the same fix for not skipping 32x32 if TU recursion is too restricted
search: create a per-depth temp buffer for temporary recon blocks
search: remove remnants of tqbypass from xRecurIntraCodingQT, improve var names
search: add tmpBits to xRecurIntraCodingQT
search: combine xRecurIntraCodingQT() bCheckFull sections
search: rename xRecurIntraCodingQT to codeIntraLumaQT, save a bit of work
search: inline single call of calcIntraLumaRecon

This allows some much needed clarity and to avoid some redundant work
search: inline single caller of xGetIntraBitsLuma, avoid extra copies
search: avoid redundant work in typical path
search: improve comments
search: remove shadow variable