more generator code