If it's not mandatory, we can leave it out, yes.
Le 20 mars 2014 02:01, "Ben Ford" <notifications@github.com> a écrit :

> In views/header.erb:
>
> > @@ -5,6 +5,10 @@
> >
> >    <link rel="stylesheet" href="<%= @asset_path %>/css/reset.css" type="text/css"/>
> >
> > +  <% if @favicon %>
> > +  <link rel="icon" type="image/jpeg" href="<%= @favicon %>"/>
>
> this will break if your favicon is a png, right? Should we just leave the
> type out?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/puppetlabs/showoff/pull/127/files#r10779315>
> .
>