I picked toString because most of our functions and methods are named in
camelCase, and all of our libraries do too except boost and stl (which are
siblings).







On Thu, May 8, 2014 at 4:38 PM, Nik Bougalis <notifications@github.com>wrote:

> In src/ripple_app/ledger/Ledger.cpp:
>
> > @@ -672,9 +672,10 @@ bool Ledger::saveValidatedLedger (bool current)
> >          DeprecatedScopedLock sl (getApp().getLedgerDB ()->getDBLock ());
> >
> >          getApp().getLedgerDB ()->getDB ()->executeSQL (boost::str (addLedger %
> > -                getHash ().GetHex () % mLedgerSeq % mParentHash.GetHex () %
> > -                beast::lexicalCastThrow <std::string> (mTotCoins) % mCloseTime % mParentCloseTime %
> > -                mCloseResolution % mCloseFlags % mAccountHash.GetHex () % mTransHash.GetHex ()));
> > +                to_string (getHash ()) % mLedgerSeq % to_string (mParentHash) %
>
> That would be nice, but I don't like the name ripple::toString and would
> much prefer to have ripple::to_string which we *already* have for some
> types and which fits with the naming convention used by the standard
> library.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ripple/rippled/pull/348/files#r12451203>
> .
>