I _think_ that is a good idea.


On Wed, May 21, 2014 at 7:56 AM, Christian Dullweber <
notifications@github.com> wrote:

> In maintenance/UpdateTable.php:
>
> > +	/**
> > +	 * @param LoadBalancer $lb
> > +	 * @param string $tableName
> > +	 * @param string $primaryKey
> > +	 */
> > +	private function clearTable( LoadBalancer $lb, $tableName, $primaryKey ) {
> > +		$db = $lb->getConnection( DB_MASTER );
> > +		if ( !$db->tableExists( $tableName ) ) {
> > +			$this->error( "$tableName table does not exist.\nExecuting core/maintenance/update.php may help.\n", true );
> > +		}
> > +		$this->output( "removing old entries\n" );
> > +		while ( 1 ) {
> > +			$db->commit( __METHOD__, 'flush' );
> > +			wfWaitForSlaves();
> > +
> > +			$idChunk = $db->select(
>
> sqlite doesn't support delete limit. but I just recognized that sqlite
> probably wont have slaves :D Maybe it would be best to have one
> insertion/deletion algorithm for mysql with limits and one without limits
> for sqlite.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Wikidata-lib/PropertySuggester/pull/44/files#r12892057>
> .
>