Since ? is a boolean operator (bool expression ? true-value : 
false-value), doing "? true : false" anywhere makes no sense imo. If you 
really want you can add "!= 0" in this case but I think most folks just 
do it as I proposed. Just my 2 cents :)

On 2-6-2014 7:01, Trent Nelson wrote:
> In xbmc/filesystem/PosixDirectory.cpp:
>
>> +    return false;
>> +
>> +  if (rmdir(strPath) == 0)
>> +    return true;
>> +  return false;
>> +}
>> +
>> +bool CPosixDirectory::Exists(const char* strPath)
>> +{
>> +  if (!strPath || !*strPath)
>> +    return false;
>> +
>> +  struct stat buffer;
>> +  if (stat(strPath, &buffer) != 0)
>> +    return false;
>> +  return S_ISDIR(buffer.st_mode) ? true : false;
>
> This was actually more correct before as it ensures the correct
> true/false values are returned. S_ISDIR just ORs out the flag value.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/xbmc/xbmc/pull/4838/files#r13285258>.
>