spec: pending specs - fixed

Change-Id: I031838a600b858717942ad4da97b57b6fcd3ed3f
Reviewed-on: https://gerrit.instructure.com/27926
Tested-by: Jenkins <jenkins@instructure.com>
Tested-by: Hannah Bottalla <hannah@instructure.com>
Reviewed-by: Hannah Bottalla <hannah@instructure.com>
QA-Review: Hannah Bottalla <hannah@instructure.com>
Product-Review: Hannah Bottalla <hannah@instructure.com>
remove canvas- from production scribd_user

closes CNVS-10190

test plan
 - in production upload a scribdable doc
 - doc should render

Change-Id: I1e6ed767fe9359250e2966bcee34c99ec1548495
Reviewed-on: https://gerrit.instructure.com/27939
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
show uncategorized account groups, fixes CNVS-10188, refs CNVS-1482

when you import groups into an account vis SIS, they are not linked to any
group set. this commit puts them in a new "Uncategorized" tab so you can
still see them and navigate to their home pages. previously you could see
them in the now-retired right sidebar.

note that there is no "Uncategorized" set in the db; we simply display a
synthetic group set that is essentially read-only.

also note that this doesn't apply to course groups, because 1. you can't
SIS import them and 2. canvas won't let you create a course group without
a group set.

test plan:
1.  do a SIS of import of some groups. for bonus points, import some users
    into those groups
2.  go to the manage groups page for the account
3.  you should see an "Uncategorized" tab at the end (always comes last)
4.  click it
5.  you should see a note explaining what these are
6.  you should not be able to delete or edit the group set
7.  you should not be able to add/edit/delete groups in the set
8.  you should be able to see the users in the groups (if any)
9.  you should not be able to reassign users (via menu or drag-and-drop)
    in the group set
10. you should be able to navigate to a given group's home page (via cog)
11. you should be able to filter groups via the search box
12. accounts without Uncategorized group sets should not have an
    Uncategorized tab
13. all other group sets (and their contents) should behave normally in
    this account and in any other course/account (general regression test)

Change-Id: Id0fa8e547bc9274a685c89d70b0cbb54ef3a01d0
Reviewed-on: https://gerrit.instructure.com/27933
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
fix spec deprecation warnings for rails 3

Change-Id: I896138df06b396b495728a6488d9780dec09d85e
Reviewed-on: https://gerrit.instructure.com/27935
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
only update rubric association peer review links for assignments

fixes CNVS-10152

test plan:
- basic regression test with rubrics and peer-reviews
  * create rubric directly on the assignment vs create rubric on the course
    and then link to the assignment
  * with the above configuration, try changing the assignment rubric after
    peer reviews have already been assigned, but not completed.
  * have multiple assignments set up as above, and make sure that step 2 only
    affects the assignment that is linked to the new rubric (and not other
    assignments with outstanding peer reviews)

Change-Id: I553361f48c4d46ccff8609b5729b1e2737c5bb37
Reviewed-on: https://gerrit.instructure.com/27868
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
added validity check to assignment_group_id in assignments api

fixes CNVS-2123

Test Plan:
  - Add assignments via the API
    - if assignment[assignment_group_id] is a string, it should fail
    - if assignment[assignment_group_id] is blank, it should succeed
    - if assignment[assignment_group_id] is a number, it should succeed
    - if assignment[assignment_group_id] is not given, it should succeed

Change-Id: I810d050e638352d8138299954e9c1195513c1d96
Reviewed-on: https://gerrit.instructure.com/27745
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Remove double quotes in generated sql query in assignment_context_scope, which fails in mysql db
move discussion_topic import to a service object

fixes CNVS-10122

test plan:
  * run specs

Change-Id: Ic13a7f41cb86812d5f268c47677161a5bd3116d8
Reviewed-on: https://gerrit.instructure.com/27810
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
refactor DiscussionTopic#process_migration

fixes CNVS-10125

test plan:
  * run specs

Change-Id: I78dde6fe0c7e80ecf9d93914878bd9e1a4827298
Reviewed-on: https://gerrit.instructure.com/27812
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
only make one request at a time in new conversations

fixes CNVS-10150

the recipients api is expensive and even canceled requests
can put the db under heavy load. this change allows a
current request to finish before starting the next request.
this means we only make one request at a time and
hopefully play a little nicer with the database.

test plan:
  * navigate to new conversations, open the new message
    dialog, and verify that the recipient finder works as
    expected. if you watch the console, you should only
    see one request open at a time.

Change-Id: I71901a2a9b7b5b3e3e4e0c290ebd0f4c84ec735e
Reviewed-on: https://gerrit.instructure.com/27917
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
remove dead grade_summary code

test plan:
- basic regression test on the grade summary page

Change-Id: If8a658ee752946af650dd1c8d59c78fce2844c60
Reviewed-on: https://gerrit.instructure.com/27869
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
remove duplicate callbacks in the Rubric model

test plan:
- basic rubric regression test

Change-Id: I2f0f7f1f34ccf15bc9673fca77e9b5625ddc445d
Reviewed-on: https://gerrit.instructure.com/27873
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
allow bundler 1.5.1 (required for ruby 2.1)

Change-Id: Ia2f535fd440a6756cee56f583e89955c249c0dc1
Reviewed-on: https://gerrit.instructure.com/27890
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fix BLTI on Ruby 2.0

Change-Id: I5082e03729e5e6a902a7edd612a935770ae3f5c0
Reviewed-on: https://gerrit.instructure.com/27952
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
styling tweaks on grade summary page

fixes CNVS-10056

test plan:
- 'Score' column header should be centered
- play with different combinations of window size and assignment title length
- the detail icons should not run off the right edge
- the 'Details' column header should be correctly hidden (but still visible to
  screenreaders)

Change-Id: Id3a1ac5fa194f49ee6992d4d4f15dba74e38afe8
Reviewed-on: https://gerrit.instructure.com/27876
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
create user merge api

closes CNVS-9084

test plan
 - merge users via api
 - should not be able to merge if you cannot manage
   both users

Change-Id: Id84995925b20ac109977a4f281c9de45a5db5a09
Reviewed-on: https://gerrit.instructure.com/27712
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Make "ColumnDatum" a proper API doc class

Removes the space in "Column Datum" so that swagger
can generate the type as a ruby class.

Test Plan:
- API docs should reflect this change

Fixes SIS-120

Change-Id: I581942b6671d73d42b63e0d0ace92bdc45622e12
Reviewed-on: https://gerrit.instructure.com/27983
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Eric Adams <eadams@instructure.com>
Product-Review: Eric Adams <eadams@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
fix creating topics via modules with draft state off

test plan:
 - with draft state off,
   - a discussion topic created via add-module-item should remain
     in the module item list after a page reload
 - with draft state on,
   - a discussion topic created via add-module-item should be
     initially unpublished

fixes CNVS-10192

Change-Id: I3504a594f0f71810ac933ae66264f54e63691e1e
Reviewed-on: https://gerrit.instructure.com/27972
Reviewed-by: Mark Severson <markse@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
fix callbacks in ruby 2.0

Change-Id: I49aa8b21eb6183a5b71b55e81e775bc0217d65f3
Reviewed-on: https://gerrit.instructure.com/26965
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fix association callback in ruby 2.0

Change-Id: I53e6caa46a27edcf117e9583b99daf2f39dc7099
Reviewed-on: https://gerrit.instructure.com/26987
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>