[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990

Unreviewed gardening.

* platform/qt-5.0-wk2/Skipped: Skip tests.
* platform/qt-5.0/Skipped: Unskip accidentally skipped tests.
* platform/qt.5-0/fast/text/whitespace/028-expected.png: Remove accidentally committed file.
* platform/qt.5-0/fast/text/whitespace/028-expected.txt: Remove accidentally committed file.
* platform/qt/Skipped: Unskip non-existing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Gardening. Skip failing tests and add a Qt specific expected file.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-30
Reviewed by Csaba Osztrogonác.

* platform/qt-4.8/Skipped: Skip svg/custom/svg-features.html.
* platform/qt/Skipped: Skip http/tests/security/contentSecurityPolicy/object-src-none-blocked.html.
* platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added because of a whitespace difference.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Adapt to changes in the SharedArray platform API
https://bugs.webkit.org/show_bug.cgi?id=92631

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-07-30
Reviewed by Rob Buis.

Adapt to changes in the SharedArray platform API. No behavioural change.

Source/WebKit/blackberry:

Reviewed internally by Joe Mason.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::getBackForwardList):
* Api/WebPage.h:
* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::runOpenPanel):

Tools:

* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::webHistoryItemCount):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Resource agent's reference to cached resources should be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108

Reviewed by Pavel Feldman.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

NetworkResourcesData now stores a raw pointer to CachedResource.
CachedResource now notifies InspectorInstrumentation that it will be destroyed.
InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
Destroyed resources content is saved to NetworkResourcesData.

Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html
       http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html

* WebCore.exp.in:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
(WebCore::InspectorInstrumentation::registerInstrumentingAgents):
(WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore):
(WebCore::InspectorResourceAgent::getResponseBody):
* inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore):
* inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::base64Encoded):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::clearPreloads):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::evict):
* testing/InternalSettings.cpp:
* testing/Internals.cpp:
(WebCore::Internals::garbageCollectDocumentResources):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unreviewed gardening. Unkskip more passing tests after bug85203.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=92642
[Bindings]Remove custom JS/V8 bindings for WebSocket::close() using [Clamp]

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-30
Reviewed by Kentaro Hara.

With support of [Clamp] as extended attribute we can replace custom bindings from WebSocket::close().
Spec for WebSocket::close() : http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#websocket

No new tests. There should be no behavioural changes
Existing tests under http/websocket/tests/hybi/ should cover this.

* Modules/websockets/WebSocket.h:
(WebCore::WebSocket::close):
* Modules/websockets/WebSocket.idl: Used [Clamp].
* bindings/js/JSWebSocketCustom.cpp: Removed custom call close().
(WebCore):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp: Removed custom call close().
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, upgrade apavlov to reviewer.
http://lists.webkit.org/mailman/private/webkit-committers/2012-July/000184.html

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=92626

Reviewed by Gustavo Noronha Silva.

Instead of always shelling out to enter a jhbuild environment, add a Python
hook for entering a jhbuild environment directly. This avoids requiring a
script to be wrapped in jhbuild.

* GNUmakefile.am: Remove gtk/run-api-tests from the distribution list.
* Scripts/run-gtk-tests: Move most of the logic from run-api-tests here
with additional code for entering a jhbuild environment directly.
* gtk/run-api-tests: Removed.
* jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py.
* jhbuild/jhbuildutils.py: Add some new helper methods here including
a method which can transform the current environment into a jhbuild-ified one.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][DRT] fast/text/font-variant-ligatures.html fails with missing rendering output
https://bugs.webkit.org/show_bug.cgi?id=85606

Unreviewed, EFL gardening.

Unskip test that's passing after r123864 due to complex font support.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-30

* platform/efl/TestExpectations: font-variant-ligatures.html unskipped.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Refactor the computation of resampled bitmap size in
drawImage and drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=92408

Reviewed by Adrienne Walker.

Source/WebCore: 

We used to have a special-purpose function called TransformDimensions()
which did pretty much the same thing as SkRect::mapRect() does.  This
change unifies the drawPattern code to use mapRect() in the same way
that drawImage() does.

Covered by existing tests, e.g., fast/backgrounds/size/*.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore):
(WebCore::Image::drawPattern):
Note:  we're now doing using the original (float) source rect, and
converting to int only after applying the matrix transform.  This
might result in different decisions about resampling mode, but it's
more correct anyway.

LayoutTests: 

Mark a test as expected to fail (will need rebaseline).

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ASSERTION FAILED: !rect.isEmpty()  : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &)
https://bugs.webkit.org/show_bug.cgi?id=92187

Reviewed by Simon Fraser.

Source/WebCore:

The border painting logic (RenderBoxModelObject::paintOneBorderSide) would pass a rect with a 0px length
to RenderObject::drawLineForBoxSide. We do check the width (thickness) but not the length so we would pass
the rect to GraphicsContext and hit the ASSERT. This change adds a check for the length too as it is the safest
way, it means that we may still do unneeded operations before bailing out but that's an existing problem in the code.

Tests: fast/borders/0px-borders-no-line-height.html
       fast/borders/double-1px-border-assert.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
Added a 0px length check. While renaming confusing variables and re-using others,
I also found a potential empty border that I fixed (tested by the 2nd case above).

LayoutTests:

* fast/borders/0px-borders-no-line-height-expected.html: Added.
* fast/borders/0px-borders-no-line-height.html: Added.
* fast/borders/double-1px-border-assert-expected.html: Added.
* fast/borders/double-1px-border-assert.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r123966 and r123967.
http://trac.webkit.org/changeset/123966
http://trac.webkit.org/changeset/123967
https://bugs.webkit.org/show_bug.cgi?id=92656

This patch is causing assertion failures on the debug bot
(also rolling out a dependent patch) (Requested by mrobinson
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/WebCore:

* GNUmakefile.am:
* GNUmakefile.list.am:
* platform/text/gtk/TextCheckerEnchant.cpp: Removed.
* platform/text/gtk/TextCheckerEnchant.h: Removed.

Source/WebKit/gtk:

* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

Source/WebKit2:

* GNUmakefile.am:
* GNUmakefile.list.am:
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitTextChecker.cpp: Removed.
* UIProcess/API/gtk/WebKitTextChecker.h: Removed.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(createDefaultWebContext):
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(beforeAll):

Tools:

* gtk/generate-gtkdoc:
(get_webkit2_options):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Added a SkiaGraphics definition to the watchlist file; cc'ed myself
to that group.  Unreviewed.

* Scripts/webkitpy/common/config/watchlist:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION: Focused TR element draws its focus outline in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=85348

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.

The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
The issue was fixed by the bug http://www.webkit.org/b/92389 .
Adding a regression test case.

* fast/table/table-row-focus-ring-paint-expected.txt: Added.
* fast/table/table-row-focus-ring-paint.html: Added.
* platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
* platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening.

Skipping a test that utilizes unsupported isolated worlds and updating
one baseline after r123988.

* platform/gtk/TestExpectations:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r124025.
http://trac.webkit.org/changeset/124025
https://bugs.webkit.org/show_bug.cgi?id=92658

Causes color-suggestion-picker-appearance layout test to time
out on all Chromium platforms (Requested by tomhudson_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/Platform:

* chromium/public/WebLocalizedString.h:

Source/WebCore:

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

Source/WebKit/chromium:

* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser):
* src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
* src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):
* src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(ColorChooserProxy):
* src/ColorChooserUIController.cpp: Removed.
* src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::didChooseColor):
(WebKit::WebColorChooserClientImpl::didEndChooser):
* src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebCore):
(WebKit):
(WebColorChooserClientImpl):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Removed.
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Removed.
* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Optimize the generation of selection details generation.
https://bugs.webkit.org/show_bug.cgi?id=92522

Reviewed by Antonio Gomes.

PR 179264.

Reduce the number of times we generate selection details notifications.

This removes several notifications that are handled by the standard
notification path and makes skipping duplicate notifications the default
so that only those that must generate a response do.

Reviewed Internally by Gen Mak.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Unreviewed gardening.  Marking two accelerated painting
tests as crashing intermittently.
https://bugs.webkit.org/show_bug.cgi?id=92660

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Turn back on ScrollbarLayerChromium for Windows
https://bugs.webkit.org/show_bug.cgi?id=92409

Reviewed by James Robinson.

This reverts r122791. As GDI issues were addressed in Chromium via
http://src.chromium.org/viewvc/chrome?view=rev&revision=148215,
scrollbar parts can now be composited on the thread.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening.

Adding platform-specific baselines that are required after r123793, r123912 and r123914.

* platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.
* platform/gtk/fast/table/table-row-outline-paint-expected.png: Added.
* platform/gtk/fast/table/table-row-outline-paint-expected.txt: Added.
* platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
* platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124053 268f45cc-cd09-0410-ab3c-d52691b4dbfc