core: rm TagDirector.GetTagIdAndParentsIds(String)

This method is not used anywhere in the code, and can safely be
removed.

Change-Id: Ia382f8ebaaa841cdd8c5bb5c52b2c2e9214df679
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Reduce scope of TagReturnValueIndicator

Since TagReturnValueIndicator is only ever used by TagDirector, it
should be an inner enum inside it, not a top level enum defined in
TagsDirector.java

Change-Id: I61b4826d09a76d0b5b1ca7ea8c18683a38ead5f1
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: TagsDirector diamond generics

Employ the new Java 7 syntax for better readability.

Change-Id: I1436de74aea2a47932d246ddf95e96a0a57baf4f
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: TagsDirector private static methods

Make private methods static where possible to enhance performance.

Change-Id: I668244c5a09e58355478b4d38a21c40ba6a48925
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: TagsDirector: use isEmpty()

Use List's isEmpty() method instead of comparing size() to 0 for
improved readability.

Change-Id: I1e6191b6ebaa4964493bbc724726fece22b31881
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: TagsDirector: precompile backshlash removal

Precompile the Pattern object used to remove backslashes. Since this
Pattern is never changed, in can be compiles once and save a heavy
operation each time the method is called.

Change-Id: I4a0ea8e5e6368b987d93bb087338df4e83318848
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: TagsDirector control flow braces

Added curly braces to control structures, as per proper Java
conventions.

Change-Id: I3d627091c2c8ef53f762f111f7c7efbdfbb300bb
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: TagsDirector method naming convention

Renamed all methods to start with lower case letters, as per proper Java
conventions.

Change-Id: I50e515e2e6634201650c1531c7e6a37b38d3228a
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: TagsDirector: stop using compat's Regex

org.ovirt.engine.core.compat.Regex is deprecated, and should only be
used for GWT-compiled classes.

This patch removes the call to Regex.IsMatch(String, String), and
replaces it with calls to equivelant calls to
java.util.regexp.Pattern.

Note: This patch does nothing but unwrap the Regex call. It's possible
there's a better way of achieving the same functionality, but that
should be left to a different patch.

Change-Id: I98c1bc6204a7bb8642e3f215b1547260f36b0152
Signed-off-by: Allon Mureinik <amureini@redhat.com>