Fixes #243 Tuples should no longer be squashed in the event store

It never gets used and I had to supply a return value. That's a good catch
maybe making this non-abstract will fix this issue.

On Wed, Nov 26, 2014 at 11:50 AM, eawagner <notifications@github.com> wrote:

> In
> commons/src/main/java/org/calrissian/accumulorecipes/commons/iterators/MetadataExpirationFilter.java:
>
> > +   * @return
> > +   */
> > +  protected long parseExpiration(long timestamp, Key k, Value v) {
> > +    curMeta = metadataSerDe.deserialize(v.get());
> > +    if(curMeta == null)
> > +      curMeta = EMPTY_LIST;
> > +
> > +    long max = -1;
> > +    for (Map<String,Object> entry : curMeta)
> > +      max = max(getExpiration(entry, -1), max);
> > +
> > +    return max;
> > +  }
> > +
> > +  @Override protected long parseTimestamp(Key k, Value v) {
> > +    return 0;
>
> Should this really be 0?
>
> I just want to make sure, because this effectively means that the
> expiration time grabbed from parseExpiration will be the time since epoch
> that triggers the filter (currentMillis() - 0).
>
> This however seems different for the EventExpirationFilter which actually
> uses a real timestamp so the expiration time required in that metadata
> would actually be a ttl value.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/calrissian/accumulo-recipes/pull/244/files#r20947274>.
>