ok i misunderstood that one. will put it in companion.


On Mon, Feb 10, 2014 at 6:51 PM, P. Oscar Boykin
<notifications@github.com>wrote:

> In algebird-core/src/main/scala/com/twitter/algebird/Monoid.scala:
>
> > @@ -225,4 +225,5 @@ object Monoid extends GeneratedMonoidImplicits with ProductMonoids {
> >    implicit def jmapMonoid[K,V : Semigroup] = new JMapMonoid[K,V]
> >    implicit def eitherMonoid[L : Semigroup, R : Monoid] = new EitherMonoid[L, R]
> >    implicit def function1Monoid[T] = new Function1Monoid[T]
> > +  implicit def streamSummaryMonoid[T]: Monoid[StreamSummary[T]] = new StreamSummaryMonoid[T]
>
> this should not go here. Only objects we don't control go here. Otherwise,
> put it in the companion object for StreamSummary.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/twitter/algebird/pull/259/files#r9608332>
> .
>