adding foodcritic as linting tool

adding foodcritic in unit tests
update attribute file to solve all foodcritic complaints