Remote Container Adapter for WLP 8.5

First crack at creating a remote adapter for WLP, tested against WLP 8.5.5.4
Cool, thanks for the feedback.

What is your test environment setup like i.e. Windows/Mac/Linux and how are
you executing?
I'm on Ubuntu 14.04 and run this with Java 1.7.0_21 and I run this all from
Maven.

Can you give me a stack trace and I'll take a look in detail. I have seen a
few 400 errors while developing this, (mostly related to GETing instead of
POSTing or wrong endpoints) off hand things some things to check

In arquillian.xml is the https port correctly set?
Is SSL certificate from the server is installed in the JVM keystore (it
must be if your getting as far as a 400)
There's a bit more documentation here -
http://clearprecision.com/arquillian-container-adapter-for-websphere-liberty-profile/

Yes I agree on failing the deployment on an Http response error. I'm still
exploring what this api returns when a file upload is successful - its
should return a 204 no content response if it works.
I'm not sure yet what else it can return in other scenarios if anything,
but at the moment I'm thinking along the lines of if not a 2xx response
then trigger a failure.



On 26 December 2014 at 11:39, Gerhard Poul <notifications@github.com> wrote:

> In
> wlp-remote-8.5/src/main/java/org/jboss/arquillian/container/was/wlp_remote_8_5/WLPRestClient.java
> <https://github.com/arquillian/arquillian-container-was/pull/22#discussion-diff-22282537>
> :
>
> > +        }
> > +
> > +        String deployPath = "${wlp.user.dir}/servers/" + configuration.getServerName() + "/dropins/"
> > +                + archive.getName();
> > +
> > +        String serverRestEndpoint = "https://" + configuration.getHostName() + ":" + configuration.getHttpsPort()
> > +                + FILE_ENDPOINT + URLEncoder.encode(deployPath, UTF_8);
> > +
> > +        int result = executor
> > +                .execute(
> > +                        Request.Post(serverRestEndpoint).useExpectContinue().version(HttpVersion.HTTP_1_1)
> > +                                .bodyFile(archive, ContentType.DEFAULT_BINARY)).returnResponse().getStatusLine()
> > +                .getStatusCode();
> > +
> > +        if (log.isLoggable(Level.INFO)) {
> > +            log.info("While deploying file " + archive.getName() + ", server returned response code " + result);
>
> I have just tested with WebSphere Liberty Profile 8.5.5.4 and get a
> response code 400 from the deployment.
>
> Any idea what could cause this? I only used your server.xml and otherwise
> a newly created server config.
>
> I also think we should fail a deployment with an appropriate error if the
> HTTP result code is not what is expected instead of just logging it as INFO.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arquillian/arquillian-container-was/pull/22/files#r22282537>
> .
>