If sdf crashes, you will get a stack trace, which is what you want when a
bug happens. Your code here even catches Error which is clearly wrong
because Errors are not catchable: the jvm throws them when it's no longer
safe to execute /anything/.
On Apr 21, 2014 11:38 AM, "Radu Mereuta" <notifications@github.com> wrote:

> In
> src/javasources/KTool/src/org/kframework/parser/generator/ParseRulesFilter.java:
>
> > @@ -175,10 +175,6 @@ else if (ss.getType().equals(Constants.RULE))
> >                  return config;
> >              } catch (TransformerException te) {
> >                  te.printStackTrace();
> > -            } catch (Exception | Error e) {
> > -                e.printStackTrace();
> > -                String msg = "Cannot parse sentence: " + e.getLocalizedMessage();
> > -                GlobalSettings.kem.register(new KException(ExceptionType.ERROR, KExceptionGroup.CRITICAL, msg, ss.getFilename(), ss.getLocation()));
>
> I'm not sure about removing this block. It provides useful information
> sometimes.
> If SDF crashed, it would be caught here and an error message shown.
> Will your modifications handle such cases?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/395/files#r11814166>
> .
>