Unreviewed gardening.

Rebaselining pixel tests after r102427

* platform/chromium-mac-lion/svg/custom/baseval-animval-equality-expected.png:
* platform/chromium-mac-lion/svg/custom/baseval-animval-equality-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/baseval-animval-equality-expected.txt.
* platform/chromium-mac-lion/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/baseval-animval-equality-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/baseval-animval-equality-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/baseval-animval-equality-expected.txt.
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-win-xp/svg/custom/baseval-animval-equality-expected.png: Added.
* platform/chromium-win-xp/svg/dom/SVGLengthList-basics-expected.png: Added.
* platform/efl-wk1/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-basics-expected.png.
* platform/gtk/svg/custom/baseval-animval-equality-expected.txt:
* platform/mac-lion/svg/custom/baseval-animval-equality-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/baseval-animval-equality-expected.txt.
* platform/mac-wk2/svg/custom/baseval-animval-equality-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/baseval-animval-equality-expected.txt.
* platform/qt/svg/custom/baseval-animval-equality-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update DOMException name: DOMStringSizeError
https://bugs.webkit.org/show_bug.cgi?id=102089

Reviewed by Ojan Vafai.

Patch 2 of 25 to update DOMException name to match the spec and Firefox.

DOMSTRING_SIZE_ERR is historical and not used in any spec or in our code.

* dom/DOMCoreException.cpp:
* dom/ExceptionCode.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. More subpixel layout test rebaselines for Windows.

* platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
* platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
* platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ASSERTION FAILED: fastAttributeLookupAllowed(name) for 7 layout tests
<http://webkit.org/b/102423>

Reviewed by Anders Carlsson.

Use Element::getAttributeItem() to find out if the element has a given attribute
instead of fastHasAttribute() since that causes assertions for the "style" attribute.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Ensure that scrollbar layers show debug borders
https://bugs.webkit.org/show_bug.cgi?id=102429

Reviewed by Anders Carlsson.

After r133517, scrollbar layers no longer showed debug borders, which
was very confusing. Fix this by explicitly calling setShowDebugBorder()
on the scrollbar-related layers owned by RenderLayerCompositor
and RenderLayerBacking.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
IndexedDB: remove setVersion from intversion-long-queue
https://bugs.webkit.org/show_bug.cgi?id=102322

Reviewed by Tony Chang.

This test probably doesn't provide as much value as it used to but
tests like this, where there's a long sequence of interdependent
events, have caught stuff for us in the past. There are endless
variants that will all exercise our code differently.

* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/resources/intversion-long-queue.js:
(prepareDatabase):
(connection1Success):
(connection1VersionChangeCallback):
(connection2Blocked):
(deleteDatabaseBlockedCallback):
(deleteDatabaseSuccessCallback):
(connection2UpgradeNeeded):
(connection2Success):
(connection2TransactionComplete):
(connection2VersionChangeEvent):
(connection3UpgradeNeeded):
(connection3Success):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Remove redundant $interfaceName from function parameters
https://bugs.webkit.org/show_bug.cgi?id=102334

Reviewed by Adam Barth.

'sub func { my $dataNode = shift; my $interfaceName = shift; }'
is redundant. We can get $interfaceName by $dataNode->name.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateOpaqueRootForGC):
(GenerateHeader):
(GenerateConstructorGetter):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateTypedArrayConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateBatchedAttributeData):
(GenerateImplementation):
(GenerateToV8Converters):
(GetNativeTypeForConversions):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=101696

Reviewed by Tony Chang.

Most of the code in StyleResolver::applyProperty assumes that isInherit implies that m_parentStyle is available.
This patch ASSERTs that this assumption is correct, and removes the few existing checks to maintain consistency.

No new tests / covered by all existing CSS tests.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Test expectations - we're passing!

Unreviewed expectations for canvas-shadow.html

* platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/canvas-shadow-expected.txt: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-shadow-expected.txt: Added.
* platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/canvas-shadow-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. CSS3_TEXT is not enabled on Windows. 
Skipping tests:
fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html
fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html
fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html

* platform/win/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove CodeGenerator::StripModule
https://bugs.webkit.org/show_bug.cgi?id=102338

Reviewed by Adam Barth.

Now WebKit IDL files have no modules. (The Web IDL spec has no modules.)
We can remove CodeGenerator::StripModule.
This might break some internal builds if the internal builds are still
using modules. Ping haraken@ you observe it.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(ForAllParents):
(AttributeNameForGetterAndSetter):
(IsStrictSubtype):
* bindings/scripts/CodeGeneratorCPP.pm:
(GetClassName):
(GetImplClassName):
(GetParentImplClassName):
(GetParent):
(ConversionNeeded):
(GetCPPTypeGetter):
(AddForwardDeclarationsForType):
(AddIncludesForType):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
(GetParentClassName):
(GetParentGObjType):
(GetClassName):
* bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(AddIncludesForTypeInImpl):
(AddIncludesForTypeInHeader):
(GenerateParametersCheckExpression):
(GenerateImplementation):
(GenerateParametersCheck):
(GetNativeTypeFromSignature):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorObjC.pm:
(GetClassName):
(GetImplClassName):
(GetParentImplClassName):
(GetParentAndProtocols):
(GetPropertyAttributes):
(ConversionNeeded):
(GetObjCTypeGetter):
(AddForwardDeclarationsForType):
(AddIncludesForType):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
(GenerateHeader):
(IsSubType):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(BaseInterfaceName):
(GetTypeFromSignature):
(IsWrapperType):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Stop using the WebCompositorSupport methods for changing settings
https://bugs.webkit.org/show_bug.cgi?id=101968

Reviewed by James Robinson.

* DumpRenderTree/chromium/TestShell.cpp:
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
mpath elements do not clear resource lists before destruction
https://bugs.webkit.org/show_bug.cgi?id=101505

Reviewed by Abhishek Arya.

Source/WebCore:

The destructor for SVGMPathElement should clear its resources before
deletion, so as not to leave hanging pointers in resource lists.

Test: svg/animations/mpath-remove-from-dependents-on-delete-crash.html

* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::~SVGMPathElement): Add destructor that calls clearResourceReferences.
(WebCore):
* svg/SVGMPathElement.h:
(SVGMPathElement): Add destructor.

LayoutTests:

Test that causes a mpath element to be deleted before the path that it
references.

* svg/animations/mpath-remove-from-dependents-on-delete-crash-expected.html: Added.
* svg/animations/mpath-remove-from-dependents-on-delete-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Ignore autocomplete=off for chrome generated passwords.
https://bugs.webkit.org/show_bug.cgi?id=102426

Patch by Yue Zhang <zysxqn@google.com> on 2012-11-15
Reviewed by Adam Barth.

Record the autocomplete attribute in the web password form data,
so that we can handle autocomplete in chromium code. The
motivation/background is: we should ignore autocomplete=off field
for password forms with chrome generated passwords (has passed
security review). By handling autocomplete in chromium code we can
distinguish password forms with chrome generated passwords and
those normal password forms. Note that we haven't turned off
checking autocomplete=off in the Webkit code for now so there is
no behavior change after this CL, and we will turn off after we
make the chromium side change to be safe.

* public/WebPasswordFormData.h:
(WebPasswordFormData):
* src/WebPasswordFormData.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Don't assert when notifyAuthReceived is called with a different auth type
https://bugs.webkit.org/show_bug.cgi?id=102436

Patch by Joe Mason <jmason@rim.com> on 2012-11-15
Reviewed by Rob Buis.

The server type could change if we contact a site taking HTTP auth, through an HTTP proxy
taking auth of its own. First we get a 407 from the proxy, and then when get past the
proxy, we get a 401 from the end site - so notifyAuthReceived gets called again with auth
type Proxy instead of HTTP.

The correct thing to do when that happens is skip the "update the auth type in the
credentials" step, since these are actually new credentials and not just credentials being
reused for a different auth type on the same server.

PR 241637

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
IndexedDB setVersion-removal batch 7
https://bugs.webkit.org/show_bug.cgi?id=102415

Reviewed by Tony Chang.

* storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
* storage/indexeddb/mozilla/readyState-expected.txt:
* storage/indexeddb/mozilla/resources/object-store-remove-values.js:
* storage/indexeddb/mozilla/resources/readyState.js:
  Moved one check into shared.js, a few others around, and the check
  for setVersion's request.readyState==pending is deleted.

* storage/indexeddb/mozilla/resources/versionchange-abort.js:
  First test I've converted that makes the initial open fail, but
  request.onsuccess is unhooked to not cause the whole test to fail.

(prepareDatabase):
(postAbort):
* storage/indexeddb/mozilla/versionchange-abort-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/odd-strings-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/resources/objectstore-basics.js:
* storage/indexeddb/resources/odd-strings.js:
* storage/indexeddb/resources/readonly.js:
  Moved the checks at the beginning to the end of the test, but
  everything was preserved.

* storage/indexeddb/resources/shared.js:
  Moved a check from readyState to here as the readyState layout test
  doesn't have access to the open request before any events are fired.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Win] key event's location does not work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=89742

Patch by Takashi Sakamoto <tasak@google.com> on 2012-11-15
Reviewed by Brent Fulgham.

As WM_KEYDOWN, WM_KEYUP, WM_SYSKEYDOWN, and WM_SYSKEYUP doesn't
directly provide a virtual keycode which distinguish between left-hand
and right-hand keys. To obtain a virtual keycode, we have to look at
lparam, i.e. scancode and extended key bit. So if the given virtual
keycode is control, shift, or menu, use MapVirtualKey with scancode and
extended key bit and recreate a virtual keycode which distinguishes
between left-hand and right-hand.

No new tests, because left-hand keys, right-hand keys layout tests
have been already added.

* platform/win/KeyEventWin.cpp:
(WebCore::windowsKeycodeWithLocation):
Use wparam and lparam to recreate a virtual keycode which distinguishes
between left-hand and right-hand if the given wparam (=virtual keycode)
is control, shift, or menu.
(WebCore):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Use the newly added function to obtain windows virtual keycode.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove methodCallDummy since it is not used anymore.

Rubber stamped by Mark Hahnenberg.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSGlobalObject):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Clean up some TestExpectations for tests that pass now.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
CallData.h should have correct indentation.

Rubber stamped by Mark Hahneberg.

* runtime/CallData.h:
(JSC):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134858 268f45cc-cd09-0410-ab3c-d52691b4dbfc