Cc pdlogs 61

Updated after review comments for the ENT feature.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against sprout_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
Fixed.

From: Eleanor Merry [mailto:notifications@github.com]
Sent: Thursday, December 18, 2014 11:52 AM
To: Metaswitch/sprout
Cc: David Collins
Subject: Re: [sprout] Cc pdlogs 61 (#895)


In include/sprout_ent_definitions.h<https://github.com/Metaswitch/sprout/pull/895#discussion-diff-22058118>:

> +(

> +  PDLogBase::CL_SPROUT_ID + 10,

> +  PDLOG_ERR,

> +  "Fatal - S-CSCF and I-CSCF enabled with no Chronos service specified in "

> +  "/etc/clearwater/config.",

> +  "The chronos_hostname=<host:port> was not set in /etc/clearwater/config.",

> +  "The application will exit and restart until the problem is fixed.",

> +  "Set the chronos_hostname=<host:port> option in the /etc/clearwater/config. "

> +  "Consult the installation instructions."

> +);

> +

> +static const PDLog CL_SPROUT_BAD_S_CSCF_JSON

> +(

> +  PDLogBase::CL_SPROUT_ID + 11,

> +  PDLOG_ERR,

> +  "Fatal - Missing or malformed /etc/clearwater/s-cscf.json file.",

I'd like to make it clearer that this is only an error on the I-CSCF, and it stops the I-CSCF from selecting an S-CSCF for a subscriber (e.g. 'The s-cscf.json file must be corrected or created to allow the I-CSCF to select an S-CSCF for a subscriber).

Also, the application won't restart - the user must correct the file and then run service sprout reload (which doesn't affect service) to pick up the changes

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/sprout/pull/895/files#r22058118>.