Bug fix for dataset surface filter.

Internal surfaces were previously shown when using polyhedron cells.

Change-Id: I377bcfd36d1ce6ebe1b8bdf25db1c286399b5729
Fix clang analyzer warning about passing null to strcmp

The pointer was being checked for null, but only logged; now return too.

Change-Id: Id9af0f968fc4fd626d9eec79af1ee22aebdc6cc6
Fixed clang analyzer warning about passing null to memcpy

In an error code path, vtkErrorMacro is used but the 'return' was omitted (every other vtkErrorMacro is paired with return), execution would then continue and pass null to memcpy.

Also removed unrelated useless test for null before using delete.

Change-Id: I9d63fae00080c2fca5974442d8bd2f936fcf0790
Fixed clang analyzer warning about reading uninitialized memory

If neither 'DMapData' nor 'MapData' get set, 'results' is read uninitialized; added 'else' case and bail out instead.

Change-Id: Ifa35e7ff76a1d3d9e74d446f1b9f3c4b42e3bc9a
Fixed clang analyzer waring about a dead store.

Useless store to local variable right before a return.

Change-Id: I0bd514edec4c7e7ac5409f68c50dae6bdee5a056
Fixed clang analyzer warning about dead store

Store to 'x' in loop is useless since it's overwritten in all cases below.

Change-Id: I6f09ecb8ca37bdbd4abe817856852354109e2e23
Fixed clang analyzer warning about dead store.

An 'abort' variable to exit a loop early was redundant with a 'break' statement in the loop.

Change-Id: Ifa7dc3bd9a58742ff9acc30de530f134e642ed85
Fixed clang analyzer warning about dead store.

An 'abort' variable to exit a loop early was redundant with a 'break' statement in the loop.

Change-Id: Iad88d4b4fbf4d3fea9ee996c6c43a4aa55fc09cd
Fixed clang analyzer warning about dead store.

Exact same assignment is made later on, and right before usage.

Change-Id: I113c924d0d0fc8b2d268cbfbdc857dcb1bd40d7a
Fixed clang analyzer warning about dead store.

Change-Id: Ica56d71e3ae4b230b5cbe97df7a784b47970fa83
Fixed clang analyzer warning about 2 dead stores.

First store is useless because 'continue' statement results in it being overwritten in the next loop.  Second is useless because value is always overwritten later before it's read.

Change-Id: Ibd5f44dc52a0e58559e4a096743fc78a509fac4d
Fixed clang analyzer warning about dead store.

The store to 'np' is definitely dead, but suspicious.  Perhaps it should be assigning to a different variable? Perhaps it's leftover copy-paste?

Change-Id: I79ec354985f7f0859b790702821a3c08520cbf5f
Fixed clang analyzer warning about reading past an array.

If GetNumberOfTuples returns more than 3 (probably never happens generally) the 'for' loop will read past the end of 'eigenvaluesGroundTruth', fixed by defensively bailing early if necessary.

Change-Id: Id7c7c6b8549b42912b993bc1582fdf69422c223f
Fixed several clang analyzer warnings.

a) suppress null deref warning with assert
b) fixed null deref of 'cell' by bailing early
c) changed error test of an existing vtkErrorMacro and added 'return' to prevent 1) infinite loop (of count VTK_LARGE_INTEGER) and 2) null deref of 'minCells'

Change-Id: Iebc64b79b51fd30ac714be4d067e344321d2a17f
Fixed clang analyzer warning about reading uninitialized memory.

If 'numDeleted' is not 2 nor 1, 'tri' was used uninitialized; call vtkErrorMacro instead.

Change-Id: Ia0e508184a37e07f3186e192a166d1f38c79cbdb
Fixed clang analyzer warning about dead store to 'pd'.

Change-Id: I361e472426ce927b301ea01a8c1a6680aa5c6438
Fixed clang analyzer warning about passing null to memcpy.

Added 'return' after an vtkErrorMacro, just like every other vtkErrorMacro in this method.

Change-Id: Ife0f7526c31b21a5e99d2abd7101a4043c4f34d1
Fixed clang analyzer warning about dead store to 'index'.

Change-Id: If42caf9e6935a098f165493bc782bfe38b553905
Fixed clang analyzer warning about dead store to 'bestTime'.

Change-Id: Ia2764b7a34514fd83e48ce10d3866f8f8091f987
Workaround clang analyzer warning by creating temp variable.

Change-Id: Idc7cafc9c7aeed9c01443efed0892cccb459ac0f