Not sure about the standard…
Should the line endings be LF or CRLF?

From: Marvin S. Addison [mailto:notifications@github.com]
Sent: 25 February 2014 04:20 PM
To: Jasig/dotnet-cas-client
Cc: Hopkins, Charles <charles@sun.ac.za>
Subject: Re: [dotnet-cas-client] NETC-56 Authentication type causes Lightswitch 2013 not to authenticate (#10)


In DotNetCasClient/Security/CasPrincipal.cs:

> -            Identity = new GenericIdentity(assertion.PrincipalName, CAS_AUTH_TYPE);

> -            Assertion = assertion;

> -            ProxyGrantingTicket = proxyGrantingTicket;

> -

> -            if (proxies != null)

> -            {

> -                Proxies = proxies;

> -            }

> -            else

> -            {

> -                Proxies = new List<string>();

> -            }

> -        }

> -        #endregion

> -    }

> -}

Please reformulate without changing whitespace. We need whitespace invariance to facilitate code review of the meaningful changes.

—
Reply to this email directly or view it on GitHub<https://github.com/Jasig/dotnet-cas-client/pull/10/files#r10036773>.

The integrity and confidentiality of this email is governed by these terms / Hierdie terme bepaal die integriteit en vertroulikheid van hierdie epos. http://www.sun.ac.za/emaildisclaimer