Make watcher identify itself on disk activation

For most jobs submitted by the watcher, it identifies
itself correctly in the reason trail. However, one
instance of an OpInstanceActivateDisk job was missed.
Fix this.

Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>
Makefile: Fix unconditional metad files in ENABLE_METADATA

Since ENABLE_METADATA is optional, they should have their own
optional section, just like ENABLE_MOND does.

Signed-off-by: Niklas Hambuechen <niklash@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>
NEWS: Mention job filters and ad-hoc filtering

These new features will be part of Ganeti 2.13.

Signed-off-by: Niklas Hambuechen <niklash@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>
Build confd by default

The only reason why it was optional was its dependency on regex-pcre,
which was an optional Ganeti dependency.

Job filter rules require rexex-pcre unconditionally, so now confd
requires no additional depdendencies and can be built by default.

Signed-off-by: Niklas Hambuechen <niklash@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>
Fix hlint warnings found by hlint 1.9.11

Our current hlint version cannot find them yet.

Signed-off-by: Niklas Hambuechen <niklash@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

Cherry-picked from: d05f1c86fcca

Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Niklas Hambuechen <niklash@google.com>
Merge branch 'stable-2.12' into stable-2.13

* stable-2.12
  Fix hlint warnings found by hlint 1.9.11
  Make watcher identify itself on disk activation

Signed-off-by: Niklas Hambuechen <niklash@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>
Merge branch 'stable-2.13' into master

* stable-2.13
  Build confd by default
  NEWS: Mention job filters and ad-hoc filtering
  Makefile: Fix unconditional metad files in ENABLE_METADATA

* stable-2.12
  Fix hlint warnings found by hlint 1.9.11
  Make watcher identify itself on disk activation

Conflicts:
  configure.ac
  lib/cmdlib/cluster/verify.py

For configure.ac, the changed section regarding confd dependencies
was removed.

For verify.py, its contents were moved to lib/cmdlib/cluster/__init__.py
so the ENABLE_CONFD bit was removed from that one.

The cabal file and Makefile.am were adjusted to remove the confd flag.

Signed-off-by: Niklas Hambuechen <niklash@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>