dockertest.subtest: Reformat logging and fix couple of bugs

This patch changes the logging method to respect these rules:
1) debug - copy&paste friendly, not necessarily nice
2) warning,error,info - manager frienly, emphasize multiline messages
                        by space-based indentation

By design this changes the issues of silently ignored messages when
lines with arguments were used (eg. `self.loginfo("test %s", 1)`)

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
docker_daemon: Adds test for testing docker daemon icc parameter.

Signed-off-by: Jiří Župka <jzupka@redhat.com>
Docker: Pylint cleanup

*  Clarify DockerContainersBase.remove_by_name() raises
   ValueError if container is not found with name.
*  Ignore SpecificServiceManager implementation pylint problems
*  More descriptive names in output.wait_for_output()
*  Fix module namespace/scoping problem in network test
*  Fix too-long line in network test
*  Fix ignoring OutputGood exception in network test.
*  Fix setting attribute outside init in network test
*  Removed TODO in help test (resolved in later version)
*  Unused import removal from syslog test

Signed-off-by: Chris Evich <cevich@redhat.com>
subtests...network: Wait for container start

Use standard utils.wait_for() call to poll on container start
to get ip address using docker inspect.  Give sufficiently
long timeout incase of image load.

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge pull request #188 from cevich/master

Network icc + fixups
dockertest: Doc. bug.

Clarify ``stuff`` and ``sub_stuff`` as dictionary-types, initialized
empty.  Using them as another type, requires re-assigning during
``initialize()`` since static assignment would otherwise get clobbered
in the constructor.

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge pull request #187 from cevich/no_clobber_stuff

dockertest: Doc. bug.
subtests...All: Pylint disable removal.

*  Disables now managed centrally in ``run_pylint.sh`` script.
*  Fixed two small pylint problems in tests

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge pull request #180 from ldoktor/logging

dockertest.subtest: Reformat logging and fix couple of bugs
dockertest.output: Log stdout/stderr when __nonzero__()

As the checker is whastly based on stdout/stderr it's essential to have
the output in case of failure.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
subtests...kill: Update & improve kill test

*  Added support for custom skipped_signals
*  Change the stress_cmd. Decrease the sleep timeout
   of the stress cmd (speedup the testing)
*  Add possibility to use ``os.kill90`` instead of
   ``docker kill`` as a test command.
*  Adds possibility to run main docker command
   as docker attach process.
*  Add 4 new tests for the sig-proxy
   feature of the main process (run or attach).
*  Improve skip_signals configuration
*  Add new test run_sigproxy test to check
   run/attach --sig-proxy feature.
*  Many Pylint/style cleanups and config. simplification
*  Update tests to work with latest docker behavior
   *  with tty=on `docker kill` => 0
   *  with tty=off `docker kill` => 255
   *  bash `kill -9 $cont_pid` => 137
   (Skip the exit code check until the behavior stabilizes)

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
subtests...kill: Message grooming

*  DockerCmd subclasses can now accept any SubBase
   derrived class.  They make use of this in logging
   messages with a more precise sub/sub-subtest name.
   Changed all calls to pass in the sub-subtest instead
   of always the parent subtest.

*  There's no need to print out all details for every single
   docker command when hundreds are run.  Defined local
   quiet/non-verbose versions of DockerCmd classes.  Enough details
   are still recorded into debug log to aid in finding any problems.

*  There were multiple nearly-identical messages printed
   by several sub-subtests.  The differences were non-
   substantial, and full details are always printed
   to the console.  Consolidated the "Missing signal" message
   and exception raising into a single method.  Removed
   details from exception and added to debug log.

*  Updated kill/stress to use Output class.

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge pull request #201 from cevich/sigproxy

Close 65 and 167
subtests...top: Clarify test image ps requirement

*  Simple default config and docs update
*  May be reverted in future if more general
   long-term solution found (e.g. automatic
   pre-test image building).

Signed-off-by: Chris Evich <cevich@redhat.com>
Doc. update: Remove redundant sections

*  Use of standard test-image options moved to
   defaults a long while ago, no need to list
   separately for tests unless they require them.
*  Same as above for ``remove_after_test`` option.
*  Cleaned out some sub-sections w/o any useful
   info.

Signed-off-by: Chris Evich <cevich@redhat.com>
subtests...tag: Fix test behavior

*  Test fails if base image doesn't exist.  Added a docker
   pull, failing with TestNAError if pull fails.
*  It was undefined whether or not upper-case names would
   be created or not.
*  Used existing 'gen_lower_only' config option to guarantee
   either all lower-case, or some upper case will appear.

Signed-off-by: Chris Evich <cevich@redhat.com>
subtests...inspect fixes

*  Bug https://bugzilla.redhat.com/show_bug.cgi?id=1092773
   opened about key naming inconsistency.
*  Note added to config w/ failing key example
*  Fixed sub_stuff typo in code

Signed-off-by: Chris Evich <cevich@redhat.com>
subtests...pull: Don't test deprecated --tag

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge pull request #191 from cevich/all_shall_pass

Tag + Inspect test bug fixes
Merge pull request #202 from cevich/topdocfix

Resolves #175