utility to combine PaymentTransactionInfoPlugins

Maybe the pull request can be simplified to hide internal changes that aren't interesting after the fact
I just used those properties for the test: they won't ever exist in real
life. Is that bad/ugly?


On Sat, Aug 16, 2014 at 8:41 AM, Pierre-Alexandre Meyer <
notifications@github.com> wrote:

> In lib/killbill/helpers/utils.rb:
>
> > +
> > +        # Create the combined transaction info and set the values
> > +        t3=Killbill::Plugin::Model::PaymentTransactionInfoPlugin.new
> > +        t3.kb_payment_id=t1.kb_payment_id
> > +        t3.kb_transaction_payment_id=t1.kb_transaction_payment_id
> > +        t3.transaction_type=t1.transaction_type
> > +        t3.amount=t1.amount
> > +        t3.currency=t1.currency
> > +        t3.created_date=t1.created_date
> > +        t3.effective_date=t1.effective_date
> > +        t3.status=t1.status==:
> PROCESSED && ( t2.nil? || t2.status==:PROCESSED) ? :PROCESSED : :ERROR
> > +        t3.gateway_error=t1.gateway_error
> > +        t3.gateway_error_code=t1.gateway_error_code
> > +        t3.first_payment_reference_id=t1.first_payment_reference_id
> > +        t3.second_payment_reference_id=t1.second_payment_reference_id
> > +        t3.test1=t1.status
>
> What are the test1 and test2 properties? They don't exist in the model,
> do they?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/killbill/killbill-plugin-framework-ruby/pull/4/files#r16325317>
> .
>



-- 
Kevin Postlewaite