Make the interna of our ra_svn protocol private.

Move svn_ra_svn__write_cmd_* functions to private/svn_ra_svn_private.h,
deprecate all low-level functions in svn_ra_svn and provide private
variants of them in the private header where necessary.

Implement the deprecated public functions in terms of our private API
and put that code into the new deprecated.c source file.  Update all
API users to call our non-deprecated private API.

* subversion/include/private/svn_ra_svn_private.h
  (svn_ra_svn__write_number,
   svn_ra_svn__write_string,
   svn_ra_svn__write_cstring,
   svn_ra_svn__write_word,
   svn_ra_svn__write_proplist,
   svn_ra_svn__start_list,
   svn_ra_svn__end_list,
   svn_ra_svn__flush,
   svn_ra_svn__write_tuple,
   svn_ra_svn__read_item,
   svn_ra_svn__skip_leading_garbage,
   svn_ra_svn__parse_tuple,
   svn_ra_svn__read_tuple,
   svn_ra_svn__parse_proplist,
   svn_ra_svn__read_cmd_response,
   svn_ra_svn__handle_commands2,
   svn_ra_svn__write_cmd_response,
   svn_ra_svn__write_cmd_failure): declare private, non-deprecated variants
  (svn_ra_svn__write_cmd_target_rev,
   svn_ra_svn__write_cmd_open_root,
   svn_ra_svn__write_cmd_delete_entry,
   svn_ra_svn__write_cmd_add_dir,
   svn_ra_svn__write_cmd_open_dir,
   svn_ra_svn__write_cmd_change_dir_prop,
   svn_ra_svn__write_cmd_close_dir,
   svn_ra_svn__write_cmd_absent_dir,
   svn_ra_svn__write_cmd_add_file,
   svn_ra_svn__write_cmd_open_file,
   svn_ra_svn__write_cmd_change_file_prop,
   svn_ra_svn__write_cmd_close_file,
   svn_ra_svn__write_cmd_absent_file,
   svn_ra_svn__write_cmd_apply_textdelta,
   svn_ra_svn__write_cmd_textdelta_chunk,
   svn_ra_svn__write_cmd_textdelta_end,
   svn_ra_svn__write_cmd_close_edit,
   svn_ra_svn__write_cmd_abort_edit,
   svn_ra_svn__write_cmd_set_path,
   svn_ra_svn__write_cmd_delete_path,
   svn_ra_svn__write_cmd_link_path,
   svn_ra_svn__write_cmd_finish_report,
   svn_ra_svn__write_cmd_abort_report,
   svn_ra_svn__write_cmd_reparent,
   svn_ra_svn__write_cmd_get_latest_rev,
   svn_ra_svn__write_cmd_get_dated_rev,
   svn_ra_svn__write_cmd_change_rev_prop2,
   svn_ra_svn__write_cmd_change_rev_prop,
   svn_ra_svn__write_cmd_rev_proplist,
   svn_ra_svn__write_cmd_rev_prop,
   svn_ra_svn__write_cmd_get_file,
   svn_ra_svn__write_cmd_update,
   svn_ra_svn__write_cmd_switch,
   svn_ra_svn__write_cmd_status,
   svn_ra_svn__write_cmd_diff,
   svn_ra_svn__write_cmd_check_path,
   svn_ra_svn__write_cmd_stat,
   svn_ra_svn__write_cmd_get_file_revs,
   svn_ra_svn__write_cmd_lock,
   svn_ra_svn__write_cmd_unlock,
   svn_ra_svn__write_cmd_get_lock,
   svn_ra_svn__write_cmd_get_locks,
   svn_ra_svn__write_cmd_replay,
   svn_ra_svn__write_cmd_replay_range,
   svn_ra_svn__write_cmd_get_deleted_rev,
   svn_ra_svn__write_cmd_get_iprops,
   svn_ra_svn__write_cmd_finish_replay): more here and "privatize"

* subversion/include/svn_ra_svn.h
  (svn_ra_svn_handle_commands,
   svn_ra_svn_write_cmd,
   svn_ra_svn_write_cmd_response,
   svn_ra_svn_drive_editor,
   svn_ra_svn_write_cmd_delete_entry,
   svn_ra_svn_write_cmd_add_dir,
   svn_ra_svn_write_cmd_finish_replay): move already deprecated API 
                                        to "deprecated" section
  (svn_ra_svn_write_number,
   svn_ra_svn_write_string,
   svn_ra_svn_write_cstring,
   svn_ra_svn_write_word,
   svn_ra_svn_write_proplist,
   svn_ra_svn_start_list,
   svn_ra_svn_end_list,
   svn_ra_svn_flush,
   svn_ra_svn_write_tuple,
   svn_ra_svn_read_item,
   svn_ra_svn_skip_leading_garbage,
   svn_ra_svn_parse_tuple,
   svn_ra_svn_read_tuple,
   svn_ra_svn_parse_proplist,
   svn_ra_svn_read_cmd_response,
   svn_ra_svn_handle_commands2,
   svn_ra_svn_write_cmd_response,
   svn_ra_svn_write_cmd_failure): deprecate & move to a common section

* subversion/libsvn_ra_svn/deprecated.c
  (): new file
  (svn_ra_svn_handle_commands,
   svn_ra_svn_write_cmd,
   svn_ra_svn_write_cmd_response,
   svn_ra_svn_drive_editor,
   svn_ra_svn_write_cmd_delete_entry,
   svn_ra_svn_write_cmd_add_dir,
   svn_ra_svn_write_cmd_finish_replay,
   svn_ra_svn_write_number,
   svn_ra_svn_write_string,
   svn_ra_svn_write_cstring,
   svn_ra_svn_write_word,
   svn_ra_svn_write_proplist,
   svn_ra_svn_start_list,
   svn_ra_svn_end_list,
   svn_ra_svn_flush,
   svn_ra_svn_write_tuple,
   svn_ra_svn_read_item,
   svn_ra_svn_skip_leading_garbage,
   svn_ra_svn_parse_tuple,
   svn_ra_svn_read_tuple,
   svn_ra_svn_parse_proplist,
   svn_ra_svn_read_cmd_response,
   svn_ra_svn_handle_commands2,
   svn_ra_svn_write_cmd_response,
   svn_ra_svn_write_cmd_failure): implement deprecated API by forwarding to
                                  our private API

* subversion/libsvn_ra_svn/marshal.c
  (svn_ra_svn_write_number,
   svn_ra_svn_write_string,
   svn_ra_svn_write_cstring,
   svn_ra_svn_write_word,
   svn_ra_svn_write_proplist,
   svn_ra_svn_start_list,
   svn_ra_svn_end_list,
   svn_ra_svn_write_tuple,
   svn_ra_svn_read_item,
   svn_ra_svn_skip_leading_garbage,
   svn_ra_svn_parse_tuple,
   svn_ra_svn_write_cmd_finish_replay): rename to ...
  (svn_ra_svn__write_number,
   svn_ra_svn__write_string,
   svn_ra_svn__write_cstring,
   svn_ra_svn__write_word,
   svn_ra_svn__write_proplist,
   svn_ra_svn__start_list,
   svn_ra_svn__end_list,
   svn_ra_svn__write_tuple,
   svn_ra_svn__read_item,
   svn_ra_svn__skip_leading_garbage,
   svn_ra_svn__parse_tuple,
   svn_ra_svn__write_cmd_finish_replay): ... these
  (vwrite_tuple_cstring,
   vwrite_tuple_cstring_opt,
   vwrite_tuple_string,
   vwrite_tuple_string_opt,
   vwrite_tuple_word,
   vwrite_tuple_word_opt,
   vwrite_tuple_revision,
   vwrite_tuple_revision_opt,
   vwrite_tuple_number,
   vwrite_tuple_boolean,
   write_tuple_cstring,
   write_tuple_cstring_opt,
   write_tuple_string,
   write_tuple_string_opt,
   write_tuple_start_list,
   write_tuple_end_list,
   write_tuple_revision,
   write_tuple_revision_opt,
   write_tuple_boolean,
   write_tuple_depth,
   vwrite_tuple,
   svn_ra_svn__read_cmd_response): call private API now
  (svn_ra_svn_read_tuple,
   svn_ra_svn_parse_proplist,
   svn_ra_svn_read_cmd_response,
   svn_ra_svn_handle_commands2,
   svn_ra_svn_write_cmd_response,
   svn_ra_svn_write_cmd_failure): rename to ...
  (svn_ra_svn__read_tuple,
   svn_ra_svn__parse_proplist,
   svn_ra_svn__read_cmd_response,
   svn_ra_svn__handle_commands2,
   svn_ra_svn__write_cmd_response,
   svn_ra_svn__write_cmd_failure): ... these; call private API now
  (svn_ra_svn_write_cmd_target_rev,
   svn_ra_svn_write_cmd_open_root,
   svn_ra_svn_write_cmd_delete_entry,
   svn_ra_svn_write_cmd_add_dir,
   svn_ra_svn_write_cmd_open_dir,
   svn_ra_svn_write_cmd_change_dir_prop,
   svn_ra_svn_write_cmd_close_dir,
   svn_ra_svn_write_cmd_absent_dir,
   svn_ra_svn_write_cmd_add_file,
   svn_ra_svn_write_cmd_open_file,
   svn_ra_svn_write_cmd_change_file_prop,
   svn_ra_svn_write_cmd_close_file,
   svn_ra_svn_write_cmd_absent_file,
   svn_ra_svn_write_cmd_apply_textdelta,
   svn_ra_svn_write_cmd_textdelta_chunk,
   svn_ra_svn_write_cmd_textdelta_end,
   svn_ra_svn_write_cmd_close_edit,
   svn_ra_svn_write_cmd_abort_edit,
   svn_ra_svn_write_cmd_set_path,
   svn_ra_svn_write_cmd_delete_path,
   svn_ra_svn_write_cmd_link_path,
   svn_ra_svn_write_cmd_finish_report,
   svn_ra_svn_write_cmd_abort_report,
   svn_ra_svn_write_cmd_reparent,
   svn_ra_svn_write_cmd_get_latest_rev,
   svn_ra_svn_write_cmd_get_dated_rev,
   svn_ra_svn_write_cmd_change_rev_prop2,
   svn_ra_svn_write_cmd_change_rev_prop,
   svn_ra_svn_write_cmd_rev_proplist,
   svn_ra_svn_write_cmd_rev_prop,
   svn_ra_svn_write_cmd_get_file,
   svn_ra_svn_write_cmd_update,
   svn_ra_svn_write_cmd_switch,
   svn_ra_svn_write_cmd_status,
   svn_ra_svn_write_cmd_diff,
   svn_ra_svn_write_cmd_check_path,
   svn_ra_svn_write_cmd_stat,
   svn_ra_svn_write_cmd_get_file_revs,
   svn_ra_svn_write_cmd_lock,
   svn_ra_svn_write_cmd_unlock,
   svn_ra_svn_write_cmd_get_lock,
   svn_ra_svn_write_cmd_get_locks,
   svn_ra_svn_write_cmd_replay,
   svn_ra_svn_write_cmd_replay_range,
   svn_ra_svn_write_cmd_get_deleted_rev,
   svn_ra_svn_write_cmd_get_iprops,
   svn_ra_svn_write_cmd_finish_replay): rename to ...
  (svn_ra_svn__write_cmd_target_rev,
   svn_ra_svn__write_cmd_open_root,
   svn_ra_svn__write_cmd_delete_entry,
   svn_ra_svn__write_cmd_add_dir,
   svn_ra_svn__write_cmd_open_dir,
   svn_ra_svn__write_cmd_change_dir_prop,
   svn_ra_svn__write_cmd_close_dir,
   svn_ra_svn__write_cmd_absent_dir,
   svn_ra_svn__write_cmd_add_file,
   svn_ra_svn__write_cmd_open_file,
   svn_ra_svn__write_cmd_change_file_prop,
   svn_ra_svn__write_cmd_close_file,
   svn_ra_svn__write_cmd_absent_file,
   svn_ra_svn__write_cmd_apply_textdelta,
   svn_ra_svn__write_cmd_textdelta_chunk,
   svn_ra_svn__write_cmd_textdelta_end,
   svn_ra_svn__write_cmd_close_edit,
   svn_ra_svn__write_cmd_abort_edit,
   svn_ra_svn__write_cmd_set_path,
   svn_ra_svn__write_cmd_delete_path,
   svn_ra_svn__write_cmd_link_path,
   svn_ra_svn__write_cmd_finish_report,
   svn_ra_svn__write_cmd_abort_report,
   svn_ra_svn__write_cmd_reparent,
   svn_ra_svn__write_cmd_get_latest_rev,
   svn_ra_svn__write_cmd_get_dated_rev,
   svn_ra_svn__write_cmd_change_rev_prop2,
   svn_ra_svn__write_cmd_change_rev_prop,
   svn_ra_svn__write_cmd_rev_proplist,
   svn_ra_svn__write_cmd_rev_prop,
   svn_ra_svn__write_cmd_get_file,
   svn_ra_svn__write_cmd_update,
   svn_ra_svn__write_cmd_switch,
   svn_ra_svn__write_cmd_status,
   svn_ra_svn__write_cmd_diff,
   svn_ra_svn__write_cmd_check_path,
   svn_ra_svn__write_cmd_stat,
   svn_ra_svn__write_cmd_get_file_revs,
   svn_ra_svn__write_cmd_lock,
   svn_ra_svn__write_cmd_unlock,
   svn_ra_svn__write_cmd_get_lock,
   svn_ra_svn__write_cmd_get_locks,
   svn_ra_svn__write_cmd_replay,
   svn_ra_svn__write_cmd_replay_range,
   svn_ra_svn__write_cmd_get_deleted_rev,
   svn_ra_svn__write_cmd_get_iprops,
   svn_ra_svn__write_cmd_finish_replay): ... these

* subversion/libsvn_ra_svn/client.c
  (parse_prop_diffs,
   parse_lock,
   svn_ra_svn__auth_response,
   handle_auth_request,
   ra_svn_set_path,
   ra_svn_delete_path,
   ra_svn_link_path,
   ra_svn_abort_report,
   handle_child_process_error,
   make_tunnel,
   open_session,
   ra_svn_reparent,
   ra_svn_rev_proplist,
   ra_svn_rev_prop,
   ra_svn_end_commit,
   ra_svn_commit,
   parse_iproplist,
   ra_svn_get_file,
   ra_svn_get_dir, 
   ra_svn_update,
   ra_svn_switch,
   ra_svn_status,
   ra_svn_diff,
   ra_svn_log, 
   ra_svn_check_path,
   ra_svn_stat,
   ra_svn_get_location_segments,
   ra_svn_lock_compat,
   ra_svn_lock,
   ra_svn_unlock,
   ra_svn_get_lock,
   ra_svn_get_locks,
   ra_svn_replay,
   ra_svn_replay_range,
   ra_svn_get_deleted_rev,
   ra_svn_get_inherited_props): use the now private ra_svn API

* subversion/libsvn_ra_svn/cram.c
  (fail,
   svn_ra_svn_cram_server,
   svn_ra_svn__cram_client): ditto

* subversion/libsvn_ra_svn/cyrus_auth.c
  (try_auth): ditto

* subversion/libsvn_ra_svn/editorp.c
  (check_for_error_internal,
   ra_svn_target_rev,
   ra_svn_open_root, 
   ra_svn_delete_entry,
   ra_svn_add_dir,
   ra_svn_open_dir,
   ra_svn_close_dir,
   ra_svn_absent_dir,
   ra_svn_add_file,
   ra_svn_open_file,
   ra_svn_close_file,
   ra_svn_absent_file,
   ra_svn_close_edit, 
   ra_svn_abort_edit,
   blocked_write,
   svn_ra_svn_drive_editor2): ditto

* subversion/libsvn_ra_svn/internal_auth.c
  (read_success): ditto

* subversion/svnserve/cyrus_auth.c
  (fail_auth,
   write_failure,
   fail_cmd,
   try_auth,
   cyrus_auth_request): ditto

* subversion/svnserve/serve.c
  (log_fail_and_flush,
   send_mechs,
   auth,
   internal_auth_request,
   set_path,
   delete_path,
   link_path,
   accept_report,
   write_prop_diffs,
   write_lock,
   reparent,
   get_latest_rev,
   get_dated_rev,
   do_change_rev_prop,
   change_rev_prop2,
   change_rev_prop, 
   rev_proplist,
   rev_prop,
   commit, 
   get_file,
   get_dir,
   update,
   switch_cmd,
   status,
   diff,
   get_mergeinfo,
   log_receiver,
   log_cmd,
   check_path,
   stat_cmd,
   get_locations,
   gls_receiver,
   svndiff_handler,
   file_rev_handler,
   get_file_revs,
   lock,
   lock_many,
   unlock,
   unlock_many,
   get_lock,
   get_locks,
   replay_one_revision,
   replay,
   replay_range,
   get_deleted_rev,
   get_inherited_props,
   serve): ditto


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1466907 13f79535-47bb-0310-9956-ffa450edef68