[ticket/11606] remove preg_replace() /e modifier in make_clickable()

PHPBB3-11606
[ticket/11832] Inject dependencies for phpbb_get_web_root_path (also moving)

Function moved from phpbb_get_web_root_path to filesystem::get_web_root_path

PHPBB3-11832
[ticket/11832] update_web_root_path helper and tests

PHPBB3-11832
[ticket/11832] Fix log tests

PHPBB3-11832
[ticket/11832] Make $phpbb_container a global initiated by the framework

Setup common items needed from the container (e.g. filesystem)

PHPBB3-11832
Revert "[ticket/11832] Make $phpbb_container a global initiated by the framework"

This reverts commit 5e09afa0bc3ff9014812282fd4454f0df54b9dfd.
[ticket/11832] Use $phpbb_filesystem instead of the container in append_sid

PHPBB3-11832
[ticket/11832] Use dirname(__FILE__)

PHPBB3-11832
[ticket/11832] More extensive testing

PHPBB3-11832
[ticket/11832] Fix the web path corrections

Add some real life examples to test

PHPBB3-11832
[ticket/11832] We must instantiate the $phpbb_filesystem in common

PHPBB3-11832
[ticket/11832] Changing comments to say app.php rather than index.php

PHPBB3-11832
Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11832

# By Joseph Warner (187) and others
# Via Andreas Fischer (2) and others
* 'develop' of github.com:phpbb/phpbb3: (189 commits)
  [ticket/11835] Fix ucp_auth_link adding in migration
  [prep-release-3.0.12] Remove changelog entry for ticket that was not resolved.
  [feature/oauth] Fix tabindex
  [feature/oauth] Fix bug on ucp_auth_link related to error display
  [feature/oauth] More small fixes
  [feature/oauth] More minor changes from review
  [feature/oauth] Fix small bug introduced by update in OAuth library
  [feature/oauth] Fix small issues on ucp pages
  [feature/oauth] Fix typo in OAuth logout method
  [feature/oauth] Make token storage service ignorant
  [feature/oauth] Update oauth::logout() to use clearAllTokens()
  [feature/oauth] Update storage implementation due to inteface change
  [feature/oauth] Update lusitanian/oauth to stable branch
  [feature/oauth] Update comment on oauth service exception
  [feature/oauth] Forgot to remove placeholder comment
  [feature/oauth] OAuth service exception
  [feature/oauth] A few more minor changes
  [feature/oauth] Changes due to code review
  [feature/oauth] Fix redirects
  [feature/oauth] Fix issues on ucp_login_link from review
  ...
[ticket/11832] Fix build_url and the S_LOGIN_ACTION

PHPBB3-11832
Merge remote-tracking branch 'remotes/imkingdavid/ticket/11824' into ticket/11832

* remotes/imkingdavid/ticket/11824:
  [ticket/11824] Revert changes in functions.php
  [ticket/11824] Reorganize test file
  [ticket/11824] Update language string for board settings
  [ticket/11824] Revert changes to functions_content.php
  [ticket/11824] Add tests for urls with mod_rewrite enabled
  [ticket/11824] Correct a comment
  [ticket/11824] Change copyright year in migration file
  [ticket/11824] Remove unused globals
  [ticket/11824] Fix smilies
  [ticket/11824] Fix logic
  [ticket/11824] Add option for mod_rewrite
Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11832

# By Nathan Guse (22) and others
# Via Nathan Guse (10) and others
* 'develop' of github.com:phpbb/phpbb3: (39 commits)
  [ticket/11843] Added newlines and included numbers in the DEFINE vars test
  [ticket/11843] Add checking DEFINE variables with underscores to template_test
  [ticket/11843] The twig lexer fixes DEFINE variables with underscores again
  [ticket/11727] Fix indentation
  [ticket/11727] Fix indentation
  [ticket/11745] Correct language, coding guidelines
  [ticket/11828] Fix greedy operators in lexer
  [ticket/11833] Prevent Twig errors from invalid template loops using BEGINELSE
  [ticket/11833] Fix bad template loop
  [ticket/11816] !$DOESNT_EXIST test
  [ticket/9550] Add the core.viewtopic_post_rowset_data event to viewtopic.php
  [ticket/11829] Use report_closed to determine status in MCP report_details
  [ticket/11816] Test !$DEFINITION
  [ticket/11822] Use namespace lookup order for asset loading
  [ticket/11727] Template loader support for safe directories to load files from
  [ticket/11816] Fix define/loop checks in IF statements containing parenthesis
  [ticket/11373] Use inheritdoc
  [ticket/11637] generate_text_for_display on search.php
  [ticket/11744] Cast to int
  [ticket/11744] Inheritdoc
  ...
[ticket/11832] Create phpbb_symfony_request to handle initiating symfony_request

Now symfony_request is also a service (removed the function
phpbb_create_symfony_request).

Inject symfony request into filesystem

Cleanup for the tests

PHPBB3-11832
Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11832

# By David King
# Via David King (1) and Joas Schilling (1)
* 'develop' of github.com:phpbb/phpbb3:
  [ticket/11824] Fix comment wording
[ticket/11832] Fix smiley paths

PHPBB3-11832
[ticket/11832] Fix constructions of phpbb_filesystem

PHPBB3-11832