PyArray_IntpFromSequence itself isn't exposed in the public API, so
changing its signature per se shouldn't affect compatibility. (Propagating
that change out through callers might I guess... we'll have to see.)


On Tue, Apr 16, 2013 at 3:27 PM, seberg <notifications@github.com> wrote:

> In numpy/core/src/multiarray/conversion_utils.c:
>
> > @@ -117,7 +118,7 @@
> >          }
> >      }
> >      seq->len = len;
> > -    nd = PyArray_IntpFromSequence(obj, (npy_intp *)seq->ptr, len);
> > +    nd = PyArray_IntpFromSequence(obj, (npy_intp *)seq->ptr, (int) len);
>
> The point of the change is to be able to avoid those errors for large
> python sequences... If we can change PyArray_IntpFromSequence to use
> npy_intp or maybe Py_ssize_t (I guess they are the same anyway?), without
> breaking binary compatibility, that wouldn't seem bad to me, even if we
> probably never use it like that.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/numpy/numpy/pull/3243/files#r3812732>
> .
>