Yea they do. We should give them a name so we know what index we're using. 

David Greenhalgh <notifications@github.com> wrote:

> + */
> +public class InstructionsDialog {
> +    private Activity activity;
> +    private static final int[] MESSAGEIDS = {R.string.welcome, R.string.welcome_connection, 
> +            R.string.welcome_music, R.string.welcome_network };
> +    
> +    public InstructionsDialog(Activity activity){
> +        this.activity = activity;
> +    }
> +    public void show(){
> +        showInstructions(0);
> +    }
> +    
> +    private void showInstructions(final int messageIndex){
> +        String positiveString = messageIndex < MESSAGEIDS.length-1?  "Next" : "Done";
> +        String negativeString = messageIndex > 0 ?  "Back" : "Skip";

Do ones and zeroes count as magic numbers in this case when they're used for indexing?

---
Reply to this email directly or view it on GitHub:
https://github.com/TheLastCrusade/SoundStream/pull/305/files#r6032122