[Security] Add PHPDoc to AuthenticationEvents
Fixed missing class argument when throwing exception
merged branch xamado/master (PR #6884)

This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #6884).

Commits
-------

c261760 Fixed missing class argument when throwing exception

Discussion
----------

Added missing parameter to Exception in DebugClassLoader

The DebugClassLoader was missing the $class argument to sprintf() when it tries to throw the exception, making the actual error you are getting more daunting :)

---------------------------------------------------------------------------

by stof at 2013-01-25T23:31:58Z

oops, sorry.

@fabpot this should be merged in 2.1 as you merged the change there
[Yaml] fixed wrong merge (indentation default is 4 as of 2.1)
Correct comment in NativeSessionStorage regarding session.save_handler

It's save_handler, not save_handlers.
merged branch igorw/session-save-handler-comment (PR #6922)

This PR was merged into the 2.1 branch.

Commits
-------

d6c0455 Correct comment in NativeSessionStorage regarding session.save_handler

Discussion
----------

Correct comment in NativeSessionStorage regarding session.save_handler

It's save_handler, not save_handlers.
merged branch franmomu/add_phpdoc_to_authentication_events (PR #6831)

This PR was merged into the 2.1 branch.

Commits
-------

e7624b6 [Security] Add PHPDoc to AuthenticationEvents

Discussion
----------

[Security] Added PHPDoc to AuthenticationEvents

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |
fixed a circular call (closes #6864)
merged branch fabpot/container-dumper-fix (PR #6959)

This PR was submitted for the 2.2 branch but it was merged into the 2.0 branch instead (closes #6959).

Commits
-------

ad889c9 [DependencyInjection] fixed a circular call (closes #6864)

Discussion
----------

[DependencyInjection] fixed a circular call (closes #6864)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6864
| License       | MIT
| Doc PR        | n/a
Merge branch '2.0' into 2.1

* 2.0:
  fixed a circular call (closes #6864)
[FrameworkBundle] removed obsolete comment (see 2e356c1)
[Security] fixed session creation when none is needed (closes #6917)
merged branch fabpot/avoid-session-creation (PR #6964)

This PR was merged into the 2.1 branch.

Commits
-------

8ca00c5 [Security] fixed session creation when none is needed (closes #6917)

Discussion
----------

[Security] fixed session creation when none is needed (closes #6917)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6917
| License       | MIT
| Doc PR        | n/a

---------------------------------------------------------------------------

by drak at 2013-02-04T16:24:49Z

That looks good. Maybe we need a test for this logic to prevent any regression in the future?

---------------------------------------------------------------------------

by bendavies at 2013-02-04T16:30:38Z

Yep, this was exactly what i tried locally, but really wasn't familiar enough with it to be confident enough to submit it as a fix.

Works for me!

---------------------------------------------------------------------------

by bendavies at 2013-02-04T17:19:32Z

A few test failures which were added by the breaking PR #2414 in the first place.

---------------------------------------------------------------------------

by fabpot at 2013-02-04T18:00:31Z

I've fixed the tests which now really test that the session is not started.
[HttpKernel] fixed the creation of the Profiler directory