Sorry, I missed this comment. I wanted to suggest moving the methods to
another component 9say a WriteSkewManager), which would know about the
clustering mode and the transaction protocol. But I guess we have enough
changes in this PR :)


On Wed, Apr 3, 2013 at 6:45 PM, Pedro Ruivo <notifications@github.com>wrote:

> In
> core/src/main/java/org/infinispan/interceptors/locking/ClusteringDependentLogic.java:
>
> > @@ -385,4 +389,64 @@ public EntryVersionsMap createNewVersionsAndCheckForWriteSkews(VersionGenerator
> >           return (uv.isEmpty()) ? null : uv;
> >        }
> >     }
> > +
> > +   /**
> > +    * Logic for total order protocol in replicated mode
> > +    */
> > +   public static final class TotalOrderReplicationLogic extends ReplicationLogic {
> > +
> > +      @Override
> > +      public EntryVersionsMap createNewVersionsAndCheckForWriteSkews(VersionGenerator versionGenerator,
>
> so, in the ReplicationLogic (and Distribution too), should I create an if
> for total order?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/infinispan/infinispan/pull/1669/files#r3639043>
> .
>