Hi Mark,

This is an old pull request, and I had a discussion with Bhavesh around
this.
I had explicitly not made any change to this file, however it was added
probably due to formatting issues. Even I saw the changes in it, and had
asked Bhavesh to not merge this request. Hence it was kept like that since
then.

Thanks,
Vimal Dhupar
Software Engineer, ICS
http://bit.ly/sbtplayground
vimal.dhupar@in.ibm.com




From:	Mark Wallace <notifications@github.com>
To:	OpenNTF/SocialSDK <SocialSDK@noreply.github.com>,
Cc:	Vimal Dhupar1/India/IBM@IBMIN
Date:	06/19/2013 12:26 PM
Subject:	Re: [SocialSDK] Adding twitter to default endpoints. (#191)



In
src/eclipse/plugins/com.ibm.sbt.core/src/com/ibm/sbt/jslibrary/servlet/LibraryServlet.java:


> @@ -237,17 +237,16 @@ protected SBTEnvironment getDefaultEnvironment
(Context context) {
>          synchronized (createEnvironmentLock) {
>              // create a default environment if needed
>              if (_defaultParams.getEnvironment() == null) {
> -                Application application = context.getApplication();
> -                String environmentName = getAppParameter(application,
PARAM_ENVIRONMENT, DEFAULT_ENVIRONMENT);
> -                SBTEnvironment environment = (SBTEnvironment)
context.getBean(environmentName);
> +                SBTEnvironment environment = (SBTEnvironment)
context.getBean(DEFAULT_ENVIRONMENT);



This change doesn't look right. I think you may be overwriting someone
else's change here. The old logic allows the default environment to be
specified using an application parameter and you are undoing this change,
can you explain why?


—
Reply to this email directly or view it on GitHub.