clear up method parameters for _modify_rules

'table_name' is always used anyway, so there's no reason to have it as
optional especially as it's not perfectly clear that it's only needed
when current_lines is empty

'binary' was never used

Change-Id: I2c6bcf3fcff1c097d1f5c5ae34aa3428a94dabdc
Extended server attributes can show wrong hypervisor_hostname

When using the extended server status (EXT-SRV-STS) extension, it might
produce the wrong hypervisor_hostname on multi-node drivers like baremetal.

The db query used is incorrect and in fact not needed anymore, since the info
is already available in the instance dict itself.

This patch resolves the issue by instead using instance['node'] directly
and further removes the no longer used compute_node_get_by_host query.

Resolves bug 1135506.

Change-Id: I641c4f59a088754fe68378ae4bf217c59056b1d1
Fixes volume attach on Hyper-V with IPv6

Fixes bug: 1148536

This patch splits the target_portal address:port pair properly in case of IPv6
addresses during login on the storage target.

Change-Id: I87c1153dd0289ac73fb35c2cd57a27d128042b2c
Check if flavor id is an empty string

Now once a flavor is created with empty string id, its id and
name cannot be specified when we use or delete the flavor.

This checks if flavorid is empty when creating a new flavor.
And if so, assigns auto-generated flavorid.

Fixes bug: 1148563

Change-Id: Ib48c4cc4ebd993d1f3f3d60a7bb856eff3c279d5
Fixes instance action exception in "evacuate" API.

'Evacuate' instance action was not created (incl. in the DB) which
caused exception to be raised during action_event_start.

Change-Id: Iec5f0a91f9b08fbdcf3ace1eaa0efbc4d9d8fc04
Fixes: bug 1152512
Revert changing to FQDN for hostnames.

5dd1553cca7f7e62eebce75e1d936fc211b239ec moved to using a FQDN for
host names. This caused bug 1151012, but Russell and I also believe
the change will break the host column on the instances table. I can't
do a plain old git revert for this change because a lot of the code
has moved after this change.

Revert to using just the hostname (no domain), and we'll revisit the
intent of 5dd1553cca7f7e62eebce75e1d936fc211b239ec separately.

Resolves bug 1151012.

Change-Id: I944f46d6eb2a6944a12833ec8de7afa2b18e66e7
Merge "Extended server attributes can show wrong hypervisor_hostname"
Merge "Fixes instance action exception in "evacuate" API."
Merge "clear up method parameters for _modify_rules"
Merge "Check if flavor id is an empty string"
Merge "Fixes volume attach on Hyper-V with IPv6"
Merge "Revert changing to FQDN for hostnames."