add more specs for edge cases