Prevent invalid code when using dynamic finders with Ruby's reserved words.

The dynamic finder was creating the method signature with the parameters name,
which may have reserved words and this way creating invalid Ruby code.

Closes: #13261

    Example:

        # Before
        Dog.find_by_alias('dog name')

        # Was creating this method
        def self.find_by_alias(alias, options = {})

        # After
        Dog.find_by_alias('dog name')

        # Will create this method
        def self.find_by_alias(_alias, options = {})
Revert the whole refactoring in the association builder classes.

This is to get activerecord-deprecated_finders work again
Make ActionDispatch::Request::Session#fetch behave like Hash#fetch

Session#fetch was mutating the session when given a default argument
and/or a block. Since Session duck-types as a Hash, it should behave
like one in these cases.
Move the parameter normalization to the initialize method

activerecord-deprecated_finders expects the parameters denormalized in
its initialize method
Merge branch 'support-deprecated-finders'
value is "disabled" not "disable"
Merge pull request #13264 from laurocaetano/fix_dynamic_finder_with_reserved_words

Prevent invalid code when using dynamic finders with reserved ruby word.
Remove not necessary file, move constants to the file they are used

File 'empty_bool.rb' was introduced around 4 years ago in
c10958fbddb22052e7cbe5fe6b825cda3cb26e48 to remove method redefined
warning in AS test suite, however we do not have such need for reuse
anymore, so we can safely move the constants back to the file where
they are currently used and get rid of the extra file/require.
Merge pull request #13280 from waynn/patch-4

value is "disabled" not "disable"
test description uses "disable" when it should be "disabled"
Warn about using `return` inside inline callback blocks [ci skip]

Closes #12981
Merge pull request #13281 from waynn/patch-5

test description uses "disable" when it should be "disabled"
Update CHANGELOG entry for Session#fetch

This reverts the changes to CHANGELOG.md in commit
38f8872aa5fd8f0a1d0895e9eb41f73261acd040.
Merge pull request #13279 from misfo/session-fetch-that-behaves-like-hash-fetch

Make ActionDispatch::Request::Session#fetch behave like Hash#fetch
typos rectified [ci skip]
Merge pull request #13284 from aayushkhandelwal11/typos_corrected

s/everytime/every time/
JSON: speed up date/time encoding

Comparing dates & times with other objects using #== is slow.
Internally, it hits #<=> which calls #to_datetime on objects
that don't respond to it, so we incur the cost of raising an
exception with a possibly-deep backtrace.

Cost of #jsonify on a Time object:

Calculating -------------------------------------
                 old      3644 i/100ms
                 new     12652 i/100ms
-------------------------------------------------
                 old    43373.8 (±3.5%) i/s -     218640 in   5.047017s
                 new   173437.6 (±5.2%) i/s -     872988 in   5.047747s
typos rectified lifecycle => life cycle
Merge pull request #13287 from aayushkhandelwal11/typo_rectified

typos rectified lifecycle => life cycle
Fix typo in action_controller responder.rb