refactor keep_old_revisions_for