I've dropped all of the nested functions and globals, I just haven't
committed yet.


On Wed, Dec 11, 2013 at 7:53 AM, Murad <notifications@github.com> wrote:

> In modules/plugx_tcp_decode.py:
>
> > +        0xC002 : "SQL_EXECUTE_STATEMENT_FLAG",
> > +        # Netstat
> > +        0xD000 : "TCPSTATE_FLAG",
> > +        0xD001 : "UDPSTATE_FLAG",
> > +        0xD002 : "ADD_TCPSTATE_FLAG",
> > +        # Keylogger
> > +        0xE000 : "KEYLOGGER_FLAG",
> > +}
> > +
> > +
> > +    module_options = { 'proto': 'tcp' }
> > +
> > +    return module_options
> > +
> > +def handleStream(tcp):
> > +    def decrypt_packed_string(__src):
>
> Concur, nested functions (nested anything, really) decreases readability
> and can sometimes make it harder to debug/troubleshoot. Would recommend
> extracting this function.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/MITRECND/chopshop/pull/21/files#r8270731>
> .
>



-- 
Kyle Creyts

Information Assurance Professional
Founder BSidesDetroit