+ 1


On Mon, Apr 1, 2013 at 3:18 AM, Eric89GXL <notifications@github.com> wrote:

> In mne/transforms/coreg.py:
>
> > +                   "create_default_subject().")
> > +            raise ValueError(err)
> > +    if mne_root is None:
> > +        mne_root = get_config('MNE_ROOT', mne_root)
> > +        if mne_root is None:
> > +            err = ("MNE_ROOT environment variable not found. Please "
> > +                   "specify the mne_root parameter in you call to "
> > +                   "create_default_subject().")
> > +            raise ValueError(err)
> > +
> > +    # make sure destination does not already exist
> > +    dest = os.path.join(subjects_dir, 'fsaverage')
> > +    if os.path.exists(dest):
> > +        err = ("Can not create fsaverage because %r already exists in "
> > +               "subjects_dir %r" % ('fsaverage', subjects_dir))
> > +        raise IOError(err)
>
> I think it would be a reasonable assumption that most people have
> fsaverage in whatever directory is returned by _get_subjects_dir() in
> mne.utils, and if they don't, it would be reasonable to make them supply
> the correct value from the command line. This would be most consistent with
> how other parts of mne-python are coded (that is, taking subjects_dir=Noneas default and using subjects_dir
> = _get_subjects_dir(subjects_dir) to get it).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/379/files#r3597663>
> .
>