Keep existing FACTERLIB value

According to http://docs.puppetlabs.com/guides/custom_facts.html
FACTERLIB variable behaves like every other load path. This change keeps
track of the already existing $FACTERLIB (if there's any) by
concatenating packstack's one to it.

Change-Id: I10ef59d5b8ee17978782a7e2a56ce2af7da72ae9
Don't define FACTERLIB when applying horizon manifest

We are exporting FACTERLIB so that we can use custom facts, this is causing
problems with the apache module. We don't need custom facts for
horizon so as a workaround we don't define FACTERLIB when applying
the horizon puppet module
https://bugzilla.redhat.com/show_bug.cgi?id=902020

A fix has been submited to the apache puppet module, once we rebase
the puppet modules we're using this commit should be reverted
https://github.com/puppetlabs/puppetlabs-apache/pull/138

Change-Id: Ibe9b5229b6f10df2a6993231289565749fe180d9
Include stdout message to ScriptRuntimeError.

Fixes rhbz#888751

Change-Id: I34d5034d77370a9ba26391e04fa79e53898f4000
Adding class['swift'] as a dependency of the ring sync

If the directory /etc/swift doesn't exist when swift::ringsync
is run, then it silently fails to copy ringfiles.  Causing
service openstack-swift-* start
to fail. This dependency causes the sync to happen after
class['swift'] when we know /etc/swift exists.
https://bugzilla.redhat.com/show_bug.cgi?id=895116

Change-Id: I919ca3f943a47e5facd1d726f4314b8d59b27f35
Merge "Include stdout message to ScriptRuntimeError."
Added random passwords for components.

Change-Id: I5a6e0dd51bfa858f1543799cf7295ec5b3c2d1ef
Fixes: rhbz#887299
Merge "Added random passwords for components."
Don't create modules' db classes if the module isn't marked for install

Since packstack introduced a DB_PW for each module, it started failing
when 1 of those modules is not marked for install because of some
missing variables in the CONF dict when formatting mysql.pp

This patch splits mysql configs per module in 3 different pp files and
includes them just when those modules are marked for install.

Fixes bz#903191

Change-Id: I7c1d86c7c80aa6e801f0ea68e2379abc01ab4967
Don't print options for regular expressions

When running in interactive mode, packstack prints options for every
command including regular expressions, since they might be confusing for
most users, packstack should not print them but use them just for
validation.

Change-Id: Ib0fae175e5c0aa6db92b5385a6448c5100a33131
Merge "Don't print options for regular expressions"
Added comments to answer file

Change-Id: Ia8924b3f786a9d455affb016e62ebcf14101b850
Fixes: rhbz#902703
Force Glance installation when Nova is being installed.

Change-Id: Ib2cd2a1f47c65cd68aa05306e8abf2e9bac7aa57
Fixes: rhbz#902485
Merge "Added comments to answer file"
The operatingsystem fact on Fedora begins in a uppercase F

The error being thrown by this on Fedora was being silently ignored
added regex for this
Also adding adding a unit test for this
Adding the effected module to pep8 tests

Change-Id: I4e4d72e6de0bce597474434a4e18112f79913718
Merge "Force Glance installation when Nova is being installed."
Load kvm modules after libvirt is installed

Nova compute fails to start on bare metal when kvm modules are not
loaded after libvirt is installed. This patch adds kvm.modules execution
after libvirt is installed.

Fixes bz#893669

Change-Id: Ia1aa17c57fb409dcd987813390c36359111316a9
Set the default indentation to 0 in inifile puppet module

A default of nil was causing problems with values when
they were commented out and didn't have a uncommented version
https://bugzilla.redhat.com/show_bug.cgi?id=903719

Also moving the inifile submodule to the packstack github org

Change-Id: Iea490a521864ad5ad02b0103299113e821fb47c2
Use /var/tmp/packstack/{%Y%m%d-%H%M} as working dir name

Collect all packstack's logs in a subdirectory called packstack and use
a '%Y%m%d-%H%M' formated datetime instead of a uuid for folder names.

Fixes bz#888360

Change-Id: Ib5a3bcc74e7819c3c3ee43d2b790922fad358e40
Merge "Set the default indentation to 0 in inifile puppet module"
Merge "Load kvm modules after libvirt is installed"