update for share code