Also, no snake case please. :-)


On Mon, Aug 5, 2013 at 10:30 PM, Patrick Wendell
<notifications@github.com>wrote:

> In core/src/main/scala/spark/executor/ExecutorSource.scala:
>
> > @@ -27,4 +43,84 @@ class ExecutorSource(val executor: Executor) extends Source {
> >    metricRegistry.register(MetricRegistry.name("threadpool", "maxPool", "size"), new Gauge[Int] {
> >      override def getValue: Int = executor.threadPool.getMaximumPoolSize()
> >    })
> > +
> > +  //Gauge got the # of bytes read in HDFS distributed file system
> > +  metricRegistry.register(MetricRegistry.name("filesystem", "hdfs", "bytesRead"), new Gauge[Long] {
> > +    override def getValue: Long = {
> > +      val stats = file_stats("hdfs")
> > +      return if (stats==null) 0 else stats.getBytesRead()
> > +    }
> > +  })
> > +
> > +  //Gauge got the # of bytes written in HDFS distributed file system
>
> We usually put a space after the comment string //
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mesos/spark/pull/783/files#r5596921>
> .
>