The rubocop check only runs if rubocop is installed/detected.


On Wed, Sep 11, 2013 at 11:38 AM, Josh Lubaway <notifications@github.com>wrote:

> In lib/pre-commit/support/templates/pre-commit-hook:
>
> > @@ -2,9 +2,7 @@
> >
> >  OPTIONS = "-r rubygems"
> >
> > -cmd = if system("which rvm > /dev/null")
> > -  "rvm default do ruby"
> > -elsif system("which rbenv > /dev/null")
> > +cmd = if system("which rbenv > /dev/null")
>
>  " make it a :development, :test dependency for the project"
>
> A lot of people who use this gem have no idea what bundler is. Many people
> use it on a clean install of OSX (or linux for that matter). Many people
> use this to check their PHP code before it is committed. Come to think of
> it, that's a good argument against adding a Ruby specific check (Rubocop)
> to the list of default checks.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jish/pre-commit/pull/81/files#r6302716>
> .
>



-- 
Juris