The Qt convention is to put the QWidget *parent last, and have it default
to 0. But do keep it, just for consistency.


On Sat, Jun 1, 2013 at 1:26 PM, Philip Kaufmann <notifications@github.com>wrote:

> In src/qt/bitcoingui.cpp:
>
> > @@ -55,7 +55,7 @@
> >
> >  const QString BitcoinGUI::DEFAULT_WALLET = "~Default";
> >
> > -BitcoinGUI::BitcoinGUI(QWidget *parent) :
> > +BitcoinGUI::BitcoinGUI(QWidget *parent, bool fIsTestnet) :
>
> Perhaps a dumb question, but do we need QWidget here? Our main window has
> no parent AFAIK, or is this Qt standard and we have to keep parent in here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcoin/bitcoin/pull/2672/files#r4489032>
> .
>