fixing long function signature