Hmmm so will you always get emailed your own comments? Or hmmm it's a sub now right, you mean there's just no easy lookup?

> On Nov 26, 2013, at 9:52, Andrea Nall <notifications@github.com> wrote:
> 
> In cgi-bin/LJ/Event/JournalNewComment.pm:
> 
> > @@ -521,6 +517,24 @@ sub matches_filter {
> >      return 0;
> >  }
> >  
> > +sub apply_noemail {
> > +    my ( $self, $watcher, $comment, $method ) = @_;
> > +
> > +    my $entry = $comment->entry;
> > +
> > +    # not a match if this user posted the entry and they don't want comments emailed,
> > +    # unless it is a reply to one of their comments or they posted the comment
> > +    my $reply_to_own_comment = $comment->parent ? $watcher->equals( $comment->parent->poster ) : 0;
> > +    my $receive_own_comment = $comment->posterid == $watcher->id # we posted
> > +                                && $watcher->prop( 'opt_getselfemail' ) && $watcher->can_get_self_email;
> 'X' means that we've converted the legacy prop ( that was either 1 or 0/non-existant ) to ESN -- I somehow must have missed this use, cause the original code is from before my patch. There's no actual way to set opt_getselfemail anyomore.
> 
> This can probably be a separate fix in this case given it was apparently there before, but this $recieve_own_comment will not behave as expected.
> 
> —
> Reply to this email directly or view it on GitHub.