I've made a new pull request with just the Makefile changes.  Should be
easier to take.


On Fri, Jul 5, 2013 at 10:38 AM, gordon.mcgregor@verilab.com <
gordon.mcgregor@verilab.com> wrote:

> Just to clean things up, I'm going to delete my fork and redo it with two
> branches for each of the changes/ pull requests.  Should end up easier.
>
>
> On Fri, Jul 5, 2013 at 10:34 AM, chiggs <notifications@github.com> wrote:
>
>> In cocotb/xunit_reporter.py:
>>
>> > +    def tail(self, lines_2find=1):
>> > +        self.seek(0, 2)                         #go to end of file
>> > +        bytes_in_file = self.tell()
>> > +        lines_found, total_bytes_scanned = 0, 0
>> > +        while (lines_2find+1 > lines_found and
>> > +               bytes_in_file > total_bytes_scanned):
>> > +            byte_block = min(1024, bytes_in_file-total_bytes_scanned)
>> > +            self.seek(-(byte_block+total_bytes_scanned), 2)
>> > +            total_bytes_scanned += byte_block
>> > +            lines_found += self.read(1024).count('\n')
>> > +        self.seek(-total_bytes_scanned, 2)
>> > +        line_list = list(self.readlines())
>> > +        return line_list[-lines_2find:]
>> > +
>> > +
>> > +class XUnitReporter:
>>
>> Shouldn't this inherit from object?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/potentialventures/cocotb/pull/34/files#r5045259>
>> .
>>
>
>
>
> --
> Dr. Gordon McGregor
> Verification Fellow
> Verilab, Inc.
> Cell: +1 (512) 577 9712
>



-- 
Dr. Gordon McGregor
Verification Fellow
Verilab, Inc.
Cell: +1 (512) 577 9712