cli: Use name instead of key for consistency

Signed-off-by: William Douglas <william.douglas@intel.com>
shared: Don't set ret to true if get didn't show a value

Signed-off-by: William Douglas <william.douglas@intel.com>
shared: Fix error with checking element twice

Signed-off-by: William Douglas <william.douglas@intel.com>
shared: Fix comment typo

Signed-off-by: William Douglas <william.douglas@intel.com>
test: Add check for parse_list delete

Signed-off-by: William Douglas <william.douglas@intel.com>
Update TODO
_cleanup_ needs a cleanup.

Make sure that these are inline, which prevents a compile
-Wunused warning. Also don't return if (!ptr), since we
don't care about doing a free(NULL) and this is shorter.
Small indent fix.
Ouch.

Hunting this error down cost... 30+ minutes.
Apply buxton string cleanup here.
More _cleanup_ stuff here.
smack: fix handling when loaded rules are absent

If there are no loaded Smack rules in /sys/fs/smackfs/load2, don't bail
with an error.

For this case, the hashmap will be empty, and only builtin rules are
considered.
smack: move access check logic to smack.c

The current access check logic is getting complex, so move it to
smack.c, and call generic functions from daemon.c instead.
daemon: add a reminder comment about moving an access check
Timing tool: deletions, layout changes.
shared: memset realloc'd memory to 0

To avoid having data in the union that wasn't set make sure to memset
the rest of a buffer after increasing the buffer's size. Size to
memset should be equal to the size requested minus the current offset
so that if we are at the 4th byte (offset=3) of a buffer size 5 we
will need to memset 2 bytes (5 - 3 = 2).
libbuxton: fix off-by-one bug in buxton_get_name
test: improvements to buxton_key_check

The one-character group/name strings were masking a bug in
buxton_get_name (see previous commit), causing later tests to fail.

Fix this by making the initial group/name strings longer, and setting
the Buxton key length manually for invalid key testcases.
smack: add placeholders for group checks
libbuxton: use set-label to create groups

Since groups only set the label member of BuxtonData, it is trivial to
create groups using the client set_label function by initializing the
group key with the label and some arbitrary data.

The handling of set_label for a group+name key remains the same.
shared: Remove extra malloc for deserialize message

This removes a massive leak where BuxtonData's there were being
allocated as a temporary store before being copied to the BuxtonData
list and never free'd as well as removes unneeded mallocs.