Hi Andrew,

I've incorporated the review comments and sent a new pull request at:
https://github.com/rackerlabs/stacktach/pull/225

The exists messages are now grouped by both owner and the message raw_id
and a verified message is sent for each group. This ensures that we send
one and only one verified message for each Glance exists message.

We've removed the intermediate commit for renaming the verified event name
as that change was incorporated in another commit made by you and has
already been merged.

Regards,
Anuj/Manali


On Fri, Oct 11, 2013 at 12:17 AM, Andrew Melton <notifications@github.com>wrote:

> In stacktach/models.py:
>
> > @@ -500,6 +508,15 @@ def mark_failed(self, reason=None):
> >              self.fail_reason = reason
> >          self.save()
> >
> > +    @staticmethod
> > +    def are_all_exists_for_owner_verified(owner, audit_period_beginning,
>
> I'm not seeing this called anywhere, is there another mechanism to check
> to make sure all of the ImageExists for a single notification have been
> verified before sending the notification?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rackerlabs/stacktach/pull/217/files#r6896521>
> .
>