finish the issue raise by ming