It's not arbitrary, it's ordered by importance/relevance, and it is an
assumption, but also a pretty reasonable one (the API would only ever have
data and and meta info.

Since you feel very strongly, though, I'll change it to just return the
whole object, which is basically the same as using a named tuple.


On Fri, Oct 18, 2013 at 3:02 PM, Ceasar Bautista
<notifications@github.com>wrote:

> In registrar.py:
>
> > +class Registrar(object):
> > +    """The client for the Registrar API"""
> > +    def __init__(self, bearer, token):
> > +        self.bearer = bearer
> > +        self.token = token
> > +
> > +    @property
> > +    def headers(self):
> > +        return {
> > +            "Authorization-Bearer": self.bearer,
> > +            "Authorization-Token": self.token,
> > +        }
> > +
> > +    def request(self, url, params=None):
> > +        """Make a signed request to the API, handling any API errors, and returning a tuple
> > +        of (data, metdata)"""
>
> Strongly disagree.
>
>    1. You're committing to us an arbitrary ordering. Intuitive isn't not
>    the word I'd use.
>    2. It clearly makes code hard to write. Consider how much simpler the
>    rest of the diff would be if it were so.
>    3. Only ever two things is an assumption.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pennappslabs/penn-sdk-python/pull/1/files#r7070963>
> .
>