I'm just curious about the implications it might have within the Shopify
codebase.

It doesn't look like any major changes have been made, though it would be
nice to keep the original test and add another test that verifies your new
functionality.

Just to ensure we don't have any regressions and such.


On 16 May 2013 05:23, Roman Smirnov <notifications@github.com> wrote:

> In test/remote/ups_test.rb:
>
> > @@ -43,7 +43,7 @@ def test_puerto_rico
> >      assert_nothing_raised do
> >        response = @carrier.find_rates(
> >                     @locations[:beverly_hills],
> > -                   Location.new(:city => 'Ponce', :country => 'US', :state => 'PR', :zip => '00733-1283'),
> > +                   Location.new(:city => 'Ponce', :country => 'PR', :zip => '00733-1283'),
>
> I think it's possible to do, but b/c possessions aren't part of the states
> list looks more properly treat them as countries.
> Besides possessions treat as countries in the Spree long time ago, ex.
> https://github.com/spree/spree/blob/2-0-stable/core/db/default/spree/countries.rb#L82
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Shopify/active_shipping/pull/58/files#r4251768>
> .
>



-- 
Chris // API & Integrations Developer @ Shopify