(maint) Fix rspec warnings

Running specs with rspec 2.13 caused a lot of warnings. Many of them actually
exposed preexisting bugs, the most common being a syntax error when expecting
an Exception. These are worth fixing even if we don't bump to rspec 2.13.
Merge pull request #1753 from pcarlisle/rspec-deprecations

(maint) Fix rspec warnings