Why would it need to? The video object that's returned has all of the
information that you need, doesn't it?

-Cale


On Fri, Jul 19, 2013 at 11:42 AM, chrisndodge <notifications@github.com>wrote:

> In common/lib/xmodule/xmodule/video_module.py:
>
> > @@ -125,7 +125,10 @@ def from_xml(cls, xml_data, system, org=None, course=None):
> >              url identifiers
> >          """
> >          video = super(VideoDescriptor, cls).from_xml(xml_data, system, org, course)
> > -        _parse_video_xml(video, xml_data)
> > +
> > +        definition_xml, location, xml_object, filepath = cls.from_xml_parser(xml_data, system, org, course)
>
> from_xml does indeed call 'from_xml_parser', but I didn't want to change
> the call signature on "from_xml" to return multiple objects (e.g.:
>
> video, definition_xml = super(VideoDescriptor, cls).from_xml(xml_data,
> system, org, course)
>
> which seemed risky
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/436/files#r5295302>
> .
>