Dan, It sounds like you have your IDE set to Java 1.5 compatibility,
whereas the maven build is explicitly stating 1.6+. Is this something you
are seeking for the project?

Here's a nice explanation of the benefits of @Override (and a mention that
@Override on interface methods is 1.6+):

http://stackoverflow.com/questions/212614/should-a-method-that-implements-an-interface-method-be-annotated-with-override

I am of course prepared to remove this instance but it seems like an
unnecessary constraint (i.e. can you imagine an organization that is using
Java 1.5 and would also be using go and NSQ?)



On Sat, Apr 13, 2013 at 6:43 PM, Dan Frank <notifications@github.com> wrote:

> In src/main/java/ly/bit/nsq/lookupd/BasicLookupdJob.java:
>
> > -		List<String> producers = lookupd.query(reader.getTopic());
> > -		for(String producer : producers) {
> > -			String[] components = producer.split(":");
> > -			String nsqdAddress = components[0];
> > -			int nsqdPort = Integer.parseInt(components[1]);
> > -			try {
> > -				reader.connectToNsqd(nsqdAddress, nsqdPort);
> > -			} catch (NSQException e) {
> > -				// TODO Auto-generated catch block
> > -				e.printStackTrace();
> > -			}
> > -		}
> > -	}
> > -	
> > -}
> > +    @Override()
>
> Alright, yeah, let's definitely get another commit in removing this line
> and then we should be just about good to go with this pull req
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitly/nsq-java/pull/3/files#r3784705>
> .
>