Make it a `git__memzero` then and let's ship this.

The idea of allocating SSH credentials even when SSH is not available
sounds just reasonable to me. Specially since you can also check for SSH
availability using the `git_libgit2_features` api call.


On Wed, Jul 10, 2013 at 12:28 AM, Russell Belfer
<notifications@github.com>wrote:

> In src/transports/cred.c:
>
> > @@ -115,48 +126,34 @@ int git_cred_ssh_keyfile_passphrase_new(
> >  	return 0;
> >  }
> >
> > -static void ssh_publickey_free(struct git_cred *cred)
> > -{
> > -	git_cred_ssh_publickey *c = (git_cred_ssh_publickey *)cred;
> > -
> > -    git__free(c->publickey);
> > -
> > -    c->sign_callback = NULL;
> > -    c->sign_data = NULL;
> > -
> > -	memset(c, 0, sizeof(*c));
>
> No, I didn't add it. It was there in the original version.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/libgit2/libgit2/pull/1695/files#r5103892>
> .
>