adding docs

No change to core