I have created a new interface PopulatorInput, with implementations 
XcriPopulatorInput and TestPopulatorInput.

On 04/02/13 15:15, Matthew Buckett wrote:
>
> In impl/src/main/java/uk/ac/ox/oucs/vle/XcriOxCapPopulatorImpl.java:
>
> > @@ -122,24 +121,34 @@ public void update(PopulatorContext context) throws PopulatorException {
> >  		
> >  		try {
> >  			URL xcri = new URL(context.getURI());
> > -		
> > -			HttpHost targetHost = new HttpHost(xcri.getHost(), xcri.getPort(), xcri.getProtocol());
> > -
> > -	        httpclient.getCredentialsProvider().setCredentials(
> > -	                new AuthScope(targetHost.getHostName(), targetHost.getPort()),
> > -	                new UsernamePasswordCredentials(context.getUser(), context.getPassword()));
> > +            InputStream input = null;
> > +
> > +            if ("file".equals(xcri.getProtocol())) {
>
> I don't think we should support file protocol on the live service 
> actually as it provides a way to read aribitary files off the 
> filesystem (eg security.properties). I'm not sure that you could 
> easily exploit this to get the output back in the browser, but it's 
> not worth the risk.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/ox-it/wl-course-signup/pull/40/files#r2877233>.
>