I don't think that's quite correct. The render system and video display are
conceptually separate. I'd be happy to refractor that, but on not too
confident with this codebase.

Thanks for the review.
On 25/02/2013 2:39 PM, "Rainer Hochecker" <notifications@github.com> wrote:

> In xbmc/Application.cpp:
>
> > @@ -914,13 +914,15 @@ bool CApplication::InitWindow()
> >    }
> >  #endif
> >
> > +  // set GUI res and force the clear of the screen
> > +  // do this first because SetViewResolution will create an OpenGL context
> > +  // and then we can init the render system from there
> > +  g_graphicsContext.SetVideoResolution(g_guiSettings.m_LookAndFeelResolution);
>
> This order doesn't make much sense. You do something with a system and
> then initialize it. In case there is something in InitRenderSystem which
> requires a bound context, this should be factored out and called by a
> separate method.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/2303/files#r3131149>.
>
>