Get tests for junit formatter working

This fixes the tests for Formatter::JUnit. The specs in `spec/cucumber/formatter/junit_spec.rb` all pass with and without `ENV['USE_LEGACY']` set. This brings the spec failures down from 20 to 3.

This branch will not merge automatically since I and @mattwynne have both been working on this and there are conflicts. How should we proceed?