install:  remove perl dependency

Change the filter in logrotate to use sed instead of perl, and remove the
package dependency on perl.

Signed-off-by: Gary Lowell  <gary.lowell@inktank.com>
cli test: add pg deep-scrub option to test

Signed-off-by: Gary Lowell  <gary.lowell@inktank.com>
rgw: create a separate logrotate file for radosgw

Fixes: #3813
Since radosgw package is separate from the ceph package,
it also needs to have a separate logrotate. The default
path for radosgw log is changed to /var/log/radosgw,
and it now has a different logrotate script.
Updating both deb and rpm packaging.

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
logrotate.conf:  Remove unneeded loop and update new rgw version.

Remove an unneeded for loop from the ceph logrotate.conf, and
update the new rgw logrotate.conf to reload the radosgw serivce.

Signed-off-by: Gary Lowell  <gary.lowell@inktank.com>
Makefile:  Add rgw/logrotate.conf source tarball

Signed-off-by: Gary Lowell  <gary.lowell@inktank.com>
WorkQueue.h: fix cast

Replace C-style pointer casting with correct static_cast<>().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
ceph_crypto.cc: remove unused shutdown() outside crypto ifdef's

Fix "out-of-line declaration of a member must be a definition
[-Wout-of-line-declaration]". Remove ceph::crypto::shutdown() outside
the crypto related ifdef's. Without nss or cryptopp configure will
fail anyways.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
obj_bencher.cc: use vector instead of VLA's

Fix "variable length array of non-POD element type" error. (-Wvla)

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
include/buffer.h: fix operator=

Fix operator=: return "iterator&" instead of 'iterator'. Check if 'this'
equals 'other' before set anything.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
include/types.h: change operator<< function parameter

Fix "Function parameter 'v' should be passed by reference." from cppchecker.
Use 'const pair<A,B>& v' similar to the other operator<< in this file.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
include/xlist.h: fix C-style pointer casting

Replace C-style pointer casting with correct static_cast<>().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
messages/MOSDRepScrub.h: initialize member variable in constructor

Initialize chunky and deep bool member variables in the constructor
with false.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
msg/Message.h: fix C-style pointer casting

Replace C-style pointer casting with correct static_cast<>().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
rbd-fuse: fix for loop in open_rbd_image()

Remove uninitialized usage of 'int i' as i++ from 'for' loop.
The variale 'i' is never used in this loop and initialized
before the next use with 0.

Related warning from clang++:

rbd_fuse/rbd-fuse.c:141:36: warning: variable 'i' is uninitialized
when used here [-Wuninitialized]
        for (im = rbd_images; im != NULL; i++, im = im->next) {

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
osd: do not spam system log on successful read_log

Signed-off-by: Sage Weil <sage@inktank.com>
test: fix Throttle unit test.

A bunch of these are slightly racy so they're enclosed in loops. This
particular one, though, changes the Throttle state in ways that
invalidate the asserts. To fix, reset the state before commencing a
rerun.

Signed-off-by: Greg Farnum <greg@inktank.com>
Merge remote-tracking branch 'gh/wip-3768'
Merge remote-tracking branch 'gh/wip-danny-cleanups'

Reviewed-by: Sage Weil <sage@inktank.com>
silence logrotate some more

I was getting email with logrotate error output from “which invoke-rc.d”
on systems without an invoke-rc.d.  This patch silences it.

Silence stderr from which when running logrotate

From: Alexandre Oliva <oliva@gnu.org>

Signed-off-by: Alexandre Oliva <oliva@gnu.org>
logrotate.conf: Silence rgw logrotate some more

Apply the same change as commit d02340d90c9d30d44c962bea7171db3fe3bfba8e to
the radosgw logrotate.conf.

Signed-off-by: Gary Lowell  <gary.lowell@inktank.com>