(maint) Fix calling wrong should method on properties

Puppet::Property defines #should, which conflicts with rspec #should. This
fixes several cases where tests were calling #should directly on a Property
instance.