[GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words
https://bugs.webkit.org/show_bug.cgi?id=115406

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-03
Reviewed by Martin Robinson.

Source/WebCore:

Replace pango API for drawing underline error on misspelled words, in favor of
drawErrorUnderline() method, removing the platform #ifdef check. As this was the
only usage of Pango in GraphicsContextCairo, it no longer includes pango.h.

* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker): Removes
pango_cairo_show_error_underline() in favor of drawErrorUnderline().
* platform/graphics/cairo/DrawErrorUnderline.h:
(drawErrorUnderline): Fills the cairo path at the end of the drawing.

LayoutTests:

Update PNG expectations for some spell checking tests to pass pixel hash comparison.
The images are not visually modified.

* platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Rebaseline
image to pass pixel hash
* platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Rebasline
image to pass pixel hash
* platform/gtk/editing/spelling/spelling-expected.png: Rebasline
image to pass pixel hash

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove XMLMIMETypeRegExp
https://bugs.webkit.org/show_bug.cgi?id=116861

Reviewed by Alexey Proskuryakov.

Remove the XMLMIMETypeRegExp class. It contained a regular expression that was used
for checking for valid XML MIME types in DOMImplementation::isXMLMIMEType. The thread-global
instance was stored in ThreadGlobalData.

The class is removed, with DOMImplementation::isXMLMIMEType now testing that the given MIME type
is of proper form and contains only valid characters.

No new tests - no change in functionality.

* dom/DOMImplementation.cpp:
(WebCore::isValidXMLMIMETypeChar): A helper method that returns true only for characters that
are acceptable in a valid XML MIME type (apart from the forward slash).
(WebCore::DOMImplementation::isXMLMIMEType): Instead of using a regular expression, determine
whether the given string is a valid non-standard XML mime type by checking for the '+xml' ending,
proper forward slash position, and that no invalid characters are used in the string.
* dom/DOMImplementation.h:
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData): The OwnPtr<XMLMIMETypeRegExp> member variable is being removed.
(WebCore::ThreadGlobalData::destroy): Ditto.
* platform/ThreadGlobalData.h:
(WebCore): No need for the XMLMIMETypeRegExp forward declaration.
(ThreadGlobalData): Remove the OwnPtr<XMLMIMETypeRegExp> member variable.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
https://bugs.webkit.org/show_bug.cgi?id=117167

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

Add WebKit::WebPage API for setting whether to show accelerated compositing
debug borders.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setShowDebugBorders):
(WebKit):
* Api/WebPage.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
AX: WebKit should join substrings on single space when concatenating the accessible name of an element
https://bugs.webkit.org/show_bug.cgi?id=117100

Reviewed by Darin Adler.

Source/WebCore:

When concatenating text from underneath an element append spaces between objects and trim whitespace.

Modified existing tests reflect the new behavior.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement):

LayoutTests:

* accessibility/text-role-with-aria-hidden-inside-expected.txt:
* accessibility/text-role-with-aria-hidden-inside.html:
* platform/mac/accessibility/internal-link-anchors2-expected.txt:
* platform/mac/accessibility/table-with-aria-role-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151131 268f45cc-cd09-0410-ab3c-d52691b4dbfc