On 03/19/2013 04:31 PM, Ionuț Arțăriși wrote:
> In attributes/server.rb:
>
>> @@ -64,9 +64,14 @@
>>    if node["platform_version"].to_f >= 12
>>      default['mysql']['pid_file']                    = "/var/run/mysql/mysqld.pid"
>>      default['mysql']['socket']                      = "/var/run/mysql/mysql.sock"
>> +    # openSUSE is running mysql >= 5.5
>> +    default["mysql"]["version"]                     = "5.5.0"
>
> I don't like this. You're hardcoding a possibly wrong version number on
> the assumption that it will only be used in my.cnf, but there's no way
> to know that someone won't start using it somewhere else in the future.

yes that's true. We can introduce another switch like generate55_my_cnf 
? What do you think about this ?


-- 
Tomasz Paszkowski
Senior Software Engineer SUSE Linux Enterprise Applications
SUSE LINUX Products GmbH
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstraße 5
90409 Nürnberg
Germany