Hi, in ps_decline_request, we did not set html_rewrite and in_place to false. Did I miss something ?

On 2013-9-24, at ÏÂÎç10:25, Jeff Kaufman <notifications@github.com> wrote:

> In src/ngx_pagespeed.cc:
> 
> > +           server_context->http_cache(),
> > +           server_context->statistics(),
> > +           message_handler);
> > +    // set in memory flag for in place_body_filter
> > +    r->filter_need_in_memory = 1;
> > +  } else {
> > +    server_context->rewrite_stats()->ipro_not_rewritable()->Add(1);
> > +    message_handler->Message(net_instaweb::kInfo,
> > +           "Could not rewrite resource in-place: %s", url.c_str());
> > +  }
> > +
> > +  ctx->driver->Cleanup();
> > +  ctx->driver = NULL;
> > +  // enable html_rewrite
> > +  ctx->html_rewrite = true;
> > +  ctx->in_place = false;
> ps_decline_request is called immediately below and not from anywhere else. There we set html_rewrite and in_place to false.  Why are we setting them here as well, and why is html_rewrite set to true?
> 
> ¡ª
> Reply to this email directly or view it on GitHub.