I was considering placing the try catch there, but felt the current location better expressed the invention of catching a whole item that had been just removed.

If we return an evicted notice would the user assume that we will display evicted notices for all items removed from the cache rather than even the timing has been just right for this issue to occur?

I'm not strongly optioned on these and happy to change the code to whatever the consensus is.

Christophe Gijbels <notifications@github.com> wrote:
>> @@ -31,13 +31,22 @@ public override object GetData(ITabContext
>context)
>>                  // if more properties want to be displayed in the
>future, here's a list of properties available
>>                  //     Value - UtcCreated - State - UtcExpires -
>SlidingExpiration - ExpiresBucket - ExpiresEntryRef 
>>                  //     UsageBucket - UsageEntryRef -
>UtcLastUsageUpdate - Dependency - Key - IsOutputCache - IsPublic
>> -                items.Add(new { 
>> -                    Key = key,
>> -                    Value =
>Serialization.GetValueSafe(cacheEnumerator.Value),
>> -                    Created = GetCacheItemProperty(key,
>"UtcCreated"),
>> -                    Expiry = GetCacheItemProperty(key,
>"UtcExpires"),
>> -                    SlidingExpiration = GetCacheItemProperty(key,
>"SlidingExpiration")
>> -                });
>> +                try
>
>I'm wondering if we should not put the `try` `catch` inside the
>`GetCacheItemProperty()`
>That way if we get an exception, you return the string `evicted` and
>then we have even more information, because we show that there was an
>item with that specific key and value but that it just got evicted, it
>might help tracking some issue (although you really have to be
>(un)lucky :wink:)
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/Glimpse/Glimpse/pull/652/files#r7917408