given you don't use link_list, I would just call each on the list of links. However, it seems that encapsulating all this ExternalDocumentStore in a single method would make more sense. I would also be tempted to put it in a class method that did the contruction and called an instance method to keep this really light.