and so empty() is redundant here, because the variable is always set.

On Thu, Jan 3, 2013 at 5:51 AM, Jari Kanerva <notifications@github.com>wrote:

> In root/includes/acp/acp_mods.php:
>
> > @@ -691,14 +644,11 @@ function mod_actions($mod_ident)
> >  			$row = $db->sql_fetchrow($result);
> >  			$db->sql_freeresult($result);
> >
> > -			if ($row)
> > -			{
> > -				return unserialize($row['mod_actions']);
> > -			}
> > -			else
> > +			if (!$row)
>
> Yes, but "!isset($var) || $var == false" do not imply that it is not set.
> You get the same result for a set but empty var. While isset don't bother
> with checking if the var contains any data.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/phpbb/automod/pull/12/files#r2535939>.
>
>