My comment about an issue was supposed to be about changing STRING to
READABLE_STRING_8 - maybe I misplaced it.

On 14 March 2013 14:44, Jocelyn Fiat <notifications@github.com> wrote:

> In library/server/wsf/extension/wsf_resource_handler_helper.e:
>
> > @@ -207,15 +260,22 @@ feature -- Handle responses
> >  	-- The option : Server-driven negotiation: uses request headers to select a variant
> >  	-- More info : http://www.w3.org/Protocols/rfc2616/rfc2616-sec12.html#sec12
> >
> > ---	supported_content_types: detachable ARRAY [READABLE_STRING_8]
> > ---			-- Supported content types
> > ---			-- Can be redefined
> > ---		do
> > ---			Result := Void
> > ---		end
> > +	--	supported_content_types: detachable ARRAY [READABLE_STRING_8]
> > +	--			-- Supported content types
> > +	--			-- Can be redefined
> > +	--		do
> > +	--			Result := Void
> > +	--		end
> > +
> > +	-- TODO: review HTTP requirements on `a_description' for each individual error code.
> >
> >  	handle_error (a_description: STRING; a_status_code: INTEGER; req: WSF_REQUEST; res: WSF_RESPONSE)
>
> What do you mean create an issue so that we don't forget to remove the
> commented line? or create an issue, so that one add content negociation
> support there? note: you are allowed and encouraged to create issue as
> well, so that no idea, request, bug ... is forgotten. I prefer to close an
> issue with a comment, rather than forgetting something
> … <#13d695c54ac6d4a3_>
> On Thu, Mar 14, 2013 at 2:49 PM, colin-adams <notifications@github.com>wrote:
> In library/server/wsf/extension/wsf_resource_handler_helper.e: > @@ -207,15
> +260,22 @@ feature -- Handle responses > -- The option : Server-driven
> negotiation: uses request headers to select a variant > -- More info :
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec12.html#sec12 > > ---
> supported_content_types: detachable ARRAY [READABLE_STRING_8] > --- --
> Supported content types > --- -- Can be redefined > --- do > --- Result :=
> Void > --- end > + -- supported_content_types: detachable ARRAY
> [READABLE_STRING_8] > + -- -- Supported content types > + -- -- Can be
> redefined > + -- do > + -- Result := Void > + -- end > + > + -- TODO:
> review HTTP requirements on `a_description' for each individual error code.
> > > handle_error (a_description: STRING; a_status_code: INTEGER; req:
> WSF_REQUEST; res: WSF_RESPONSE) Agreed. Will you create n issue for this so
> we don't forget it? — Reply to this email directly or view it on GitHub<
> https://github.com/EiffelWebFramework/EWF/pull/40/files#r3372905> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/EiffelWebFramework/EWF/pull/40/files#r3373899>
> .
>