I already commented in the tests we should not inherit the input options in
the label, we need only the three I listed there.

Sent using mobile Gmail
On Dec 2, 2013 11:19 AM, "Yves Senn" <notifications@github.com> wrote:

> In actionview/lib/action_view/helpers/tags/collection_helpers.rb:
>
> > @@ -18,7 +18,10 @@ def initialize(template_object, object_name, method_name, object,
> >            end
> >
> >            def label(label_html_options={}, &block)
> > -            html_options = label_html_options.merge(@input_html_options)
> > +            html_options = label_html_options.merge(@input_html_options) do |_, new_value, old_value|
>
> One thing to consider if we expect all options to be combined or only
> :class. I imagine there are options where passing an Array would not make
> sense or is invalid.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rails/rails/pull/13122/files#r8024518>
> .
>